Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default N Efficiencies for Crops, Tillage #3224

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@rajadain
Copy link
Member

rajadain commented Jan 7, 2020

Overview

Updates default Nitrogen efficiencies for Cover Crops and Conservation Tillage as specified. Also refactors the code to be less redundant.

Note that this is targeted against the release/1.26.0 branch, not develop.

Connects #3223

Demo

image

Testing Instructions

  • Checkout this branch and reload app and worker (necessary because the changes in gwlfe_settings are not picked up until the server is restarted)
    $ vagrant reload app worker
  • Rebuild the bundle
    $ ./scripts/bundle.sh --debug
  • Go to :8000 and select / draw a shape
  • Model it using MapShed. Click "Add changes to this area"
  • Click the "Settings" button in the top-right corner
  • Ensure the dialog has the new values as shown
rajadain added 2 commits Jan 7, 2020
Previously the literal values were specified in two
separate places, carrying the risk of inconsistency
if one was updated without the other. By exporting
and importing the values to reuse them, we ensure
that the literals are specified only once, and now
can be updated in a single place, to have consistent
effect throughout the app.
Refs #3223
@rajadain rajadain added the PA DEP label Jan 7, 2020
@rajadain rajadain requested a review from mmcfarland Jan 7, 2020
Copy link
Member

mmcfarland left a comment

Confirmed that the new values are shown in the settings dialog. Nice targeted refactor as well.

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Jan 7, 2020
@rajadain rajadain merged commit cdf5962 into release/1.26.0 Jan 7, 2020
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4136 succeeded in 10 min
Details
@rajadain rajadain deleted the tt/update-default-n-efficiencies branch Jan 7, 2020
@rajadain

This comment has been minimized.

Copy link
Member Author

rajadain commented Jan 7, 2020

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.