Change input format. #35
Conversation
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| setup( | |||
| name='tr55', | |||
| version='0.1.0.dev2', | |||
| version='0.1.0.dev3', | |||
There was a problem hiding this comment.
We shouldn't include the version changes here or in the changlog. Let's add the new functionality and do a separate release and commit when we're ready. Also, we've dropped the dev* suffix. Since this has breaking changes, we should release it as 0.2.0 when we do.
|
Tests pass & this looks good to me, 👍 |
|
Okay, I would like to add a couple of additional tests, then I will squash and merge. |
The modification types "bmp" and "reclassification" have been unified into a single type: "change". For a modification, the word "change" is given as a key with an associated value which is a string of the form "soil:landuse:bmp". Any missing items (for example, soil and landuse when a BMP is being represented) can simply be left blank (for example, "::green_roof"). This is in service of WikiWatershed/model-my-watershed#585
|
Do we want to cut a new release of this now? |
|
I have made all of the changes that I need/want for the Geotrellis integration. We do still have an open card related to disquiet amongst some reviewers over the data used for the mini-app: that could require another change to this code. |
|
Is that in this sprint or further out? No harm in cutting multiple releases if we want to pin something in the main MMW project to a real release vs. a Git branch. |
|
I think the card is in the "in progress" column. I have no problem with a release, but perhaps @mmcfarland should weigh in. |
The modification types "bmp" and "reclassification" have been unified into a single type: "change".
For a modification, the word "change" is given as a key with an associated value which is a string of the form "soil:landuse:bmp". Any missing items (for example, soil and landuse when a BMP is being represented) can simply be left blank (for example, "::green_roof").
This is in service of WikiWatershed/model-my-watershed#585