Skip to content

CON-718 #3018

Merged
merged 3 commits into from Mar 5, 2014

4 participants

@vforge
vforge commented Mar 5, 2014

No description provided.

@vforge
vforge commented Mar 5, 2014

LGTM

@macbre
macbre commented Mar 5, 2014

The more red the better :) 👍

@macbre
macbre commented Mar 5, 2014

Consider removing AssetsManagerBaseBuilder::mCacheMode as it's now always set to public (was private for site_user_css package). This will allow us to remove getCacheMode method.

@SebastianMarzjan

@macbre Thanks for noticing, I'll take a look tomorrow unless it's something you guys want to do it as part of caching initiative

@macbre
macbre commented Mar 5, 2014

Nothing urgent. You can make these changes tomorrow :)

@lukaszkonieczny

I'm merging this PR and removing AssetsManagerBaseBuilder::mCacheMode will be consider in another one.

@lukaszkonieczny lukaszkonieczny merged commit 8101c89 into dev Mar 5, 2014
@lukaszkonieczny lukaszkonieczny deleted the CON-718 branch Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.