XW-1687 | static logged in global nav #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warkot
changed the title
components/global-navigation.md
Outdated
| </svg> | ||
| </a> | ||
|
|
||
| <a href="#" class="wds-button wds-is-squished wds-global-navigation__start-a-wiki wds-is-secondary">Start a wiki</a> |
There was a problem hiding this comment.
I feel these classes should be sorted somehow differently. Maybe like this?
wds-button wds-is-squished wds-is-secondary wds-global-navigation__start-a-wiki
Contributor
Author
There was a problem hiding this comment.
Probably it should be discussed here #57, where the button are added.
|
One minor thing but LGTM |
components/global-navigation.md
Outdated
| </svg> | ||
| </a> | ||
|
|
||
| <a href="#" class="wds-global-navigation__content-bar wds-has-fixed-width wds-is-green">Games</a> |
There was a problem hiding this comment.
I think we should use wds-is-games instead of wds-is-green. API will control this class and I don't think it should control the colors.
There was a problem hiding this comment.
Also, this is what we use in the footer:
<li class="wds-global-footer__links-list-item">
<a href="#" class="wds-global-footer__link wds-is-games">
<div>Games</div>
added 17 commits
August 25, 2016 15:12
…d :hover selectors to match LVHA-order
components/global-navigation.md
Outdated
| </div> | ||
| <div class="wds-dropdown-content wds-global-navigation__dropdown"> | ||
| <ul class="wds-list wds-has-lines-between"> | ||
| <li><button class="wds-button wds-is-full-width">Sign in</button></li> |
Contributor
There was a problem hiding this comment.
Please fix indentation
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/XW-1687
Wikia/design-system#37
@Wikia/x-wing