Skip to content

Conversation

@lizlux
Copy link
Contributor

@lizlux lizlux commented Mar 8, 2017

The border: 1px solid; property was overriding the border color set in the mixin. This will let border color, width, and style be set independently of one another. Should fix the 1px height difference above and below primary buttons.
screen shot 2017-03-08 at 2 16 23 pm

@Wikia/x-wing @vforge

@rogatty
Copy link

rogatty commented Mar 8, 2017

Please take a look at http://fandomdesignsystem.com/#/overview/contributing and:

  • run npm run build to update the dist directory
  • after this is merged to master, run npm run release-fix which will create the release and bump the package.json version
  • update changelog on https://github.com/Wikia/design-system/releases

The change itself LGTM.

@lizlux
Copy link
Contributor Author

lizlux commented Mar 9, 2017

Thanks @rogatty! Project is built.

@lizlux lizlux merged commit 51c26ac into master Mar 9, 2017
@lizlux lizlux deleted the button-border branch March 9, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants