Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proposer name on suggestion page #527

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

rajarshi-ch
Copy link
Contributor

Description

Added proposer name.

The suggest page now shows the user name of the proposer of each suggested partner.
It also links to the user's CentralAuth page via user.wp_link_central_auth.

Rationale

Phabricator Ticket

https://phabricator.wikimedia.org/T218849

How Has This Been Tested?

Tested offline with the sample data.

Screenshots of your changes (if appropriate):

image

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@rajarshi-ch rajarshi-ch changed the title Rajarshi Show proposer name on suggestion page Sep 19, 2020
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the Wikipedia Library! This is looking good, although this needs some changes before I can move to merge this. Let me know if you have any questions.

TWLight/resources/templates/resources/suggest.html Outdated Show resolved Hide resolved
Co-authored-by: Susana Cárdenas Molinar <7854953+suecarmol@users.noreply.github.com>
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes made! This looks good to go! Moving to merge this.

@suecarmol suecarmol merged commit 350e5f1 into WikipediaLibrary:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants