Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create login partial view #718

Merged
merged 11 commits into from May 27, 2021
Merged

Create login partial view #718

merged 11 commits into from May 27, 2021

Conversation

suecarmol
Copy link
Contributor

Description

Create the upper part of the new Wikipedia Library Homepage, compatible with RTL languages and with different mobile devices.

Rationale

This is part of our site's redesign efforts.

Phabricator Ticket

T282115

How Has This Been Tested?

Tested in different screen sizes and different languages In the web browser (Firefox)

Screenshots of your changes (if appropriate):

Laptop screen
Screen Shot 2021-05-24 at 19 38 06

Mobile screen
Captura de pantalla 2021-05-25 - 19 38 28

Tablet screen
Captura de pantalla 2021-05-25 - 19 38 34

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good on desktop and tablet, but there are a few minor issues for mobile.

TWLight/static/css/new-local.css Show resolved Hide resolved
TWLight/static/css/new-local.css Show resolved Hide resolved
@jsnshrmn
Copy link
Member

This looks good to me! Waiting on other team feedback to merge. Feel free to do so if you get the green light!

@jsnshrmn
Copy link
Member

This is looking good, though it looks like the rtl stylesheet needs to be regenerated.

@suecarmol
Copy link
Contributor Author

though it looks like the rtl stylesheet needs to be regenerated.

I don't understand this comment. I don't think I deleted the RTL stylesheet.

@jsnshrmn
Copy link
Member

The RTL file looks out of sync with the main one, at least in the gh review diff. Sometimes gh gets a little wacky, so I can pull it down to double check

@suecarmol
Copy link
Contributor Author

The RTL file looks out of sync with the main one, at least in the gh review diff. Sometimes gh gets a little wacky, so I can pull it down to double check

Oh, got it! I found several redundant css classes. Will push a new commit shortly

Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jsnshrmn jsnshrmn merged commit 5cd0553 into WikipediaLibrary:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants