New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create login partial view #718
Create login partial view #718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good on desktop and tablet, but there are a few minor issues for mobile.
This looks good to me! Waiting on other team feedback to merge. Feel free to do so if you get the green light! |
This is looking good, though it looks like the rtl stylesheet needs to be regenerated. |
I don't understand this comment. I don't think I deleted the RTL stylesheet. |
The RTL file looks out of sync with the main one, at least in the gh review diff. Sometimes gh gets a little wacky, so I can pull it down to double check |
Oh, got it! I found several redundant css classes. Will push a new commit shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Create the upper part of the new Wikipedia Library Homepage, compatible with RTL languages and with different mobile devices.
Rationale
This is part of our site's redesign efforts.
Phabricator Ticket
T282115
How Has This Been Tested?
Tested in different screen sizes and different languages In the web browser (Firefox)
Screenshots of your changes (if appropriate):
Laptop screen
Mobile screen
Tablet screen
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: