Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for linear objectives #61

Merged
merged 9 commits into from Jan 21, 2020
Merged

Support for linear objectives #61

merged 9 commits into from Jan 21, 2020

Conversation

@Wikunia
Copy link
Owner

Wikunia commented Jan 16, 2020

Support for linear objectives #38
Test case from: #57

Ole
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #61 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   98.79%   98.93%   +0.14%     
==========================================
  Files          20       20              
  Lines        1405     1405              
==========================================
+ Hits         1388     1390       +2     
+ Misses         17       15       -2
Impacted Files Coverage Δ
src/eq_sum.jl 100% <100%> (ø) ⬆️
src/util.jl 100% <100%> (ø) ⬆️
src/Variable.jl 100% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02268c9...faef4a7. Read the comment docs.

@Wikunia

This comment has been minimized.

Copy link
Owner Author

Wikunia commented Jan 17, 2020

Add a test for constant in objective function and bugfix for logging as TreeLogNode.best_boundis still Int

docs/src/how_to.md Outdated Show resolved Hide resolved
src/ConstraintSolver.jl Outdated Show resolved Hide resolved
test/fcts.jl Outdated Show resolved Hide resolved
test/fcts.jl Outdated Show resolved Hide resolved
test/fcts.jl Outdated Show resolved Hide resolved
test/fcts.jl Outdated Show resolved Hide resolved
test/fcts.jl Outdated Show resolved Hide resolved
@matbesancon

This comment has been minimized.

Copy link
Contributor

matbesancon commented Jan 17, 2020

in general, use Int instead of Int64, shorter alias

Wikunia and others added 2 commits Jan 17, 2020
Co-Authored-By: Mathieu Besançon <mathieu.besancon@gmail.com>
src/ConstraintSolver.jl Outdated Show resolved Hide resolved
test/graph_color.jl Outdated Show resolved Hide resolved
@Wikunia Wikunia merged commit 2d9fbe3 into master Jan 21, 2020
16 checks passed
16 checks passed
build (1.2.0, x86, ubuntu-latest)
Details
build (1.2.0, x86, ubuntu-latest)
Details
test (1.0.4, x64, ubuntu-latest)
Details
test (1.0.4, x64, ubuntu-latest)
Details
test (1.0.4, x64, windows-latest)
Details
test (1.0.4, x64, windows-latest)
Details
test (1.0.4, x64, macOS-latest)
Details
test (1.0.4, x64, macOS-latest)
Details
test (1.2.0, x64, ubuntu-latest)
Details
test (1.2.0, x64, ubuntu-latest)
Details
test (1.2.0, x64, windows-latest)
Details
test (1.2.0, x64, windows-latest)
Details
test (1.2.0, x64, macOS-latest)
Details
test (1.2.0, x64, macOS-latest)
Details
codecov/patch 100% of diff hit (target 98.79%)
Details
codecov/project 98.93% (+0.14%) compared to 02268c9
Details
@Wikunia Wikunia deleted the feature-linear-objective branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.