Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFA-415: Add accessible labels to buttons on Officer Profile screen #431

Merged
merged 4 commits into from Oct 26, 2020

Conversation

CR96
Copy link
Contributor

@CR96 CR96 commented Oct 24, 2020

Related Issue

Fixes #415.

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)
  • This change depends O-FISH Web repository changes (explain below)
  • Optional: Add any explanations here

  • Optional: Add any relevant screenshots here

@CR96
Copy link
Contributor Author

CR96 commented Oct 24, 2020

@Sheeri This is complete, it's just missing translations for "Close" and "Change Profile Picture." Have you been translating by hand or using a service?

And I think the CI build failure is a Docker or NPM issue, not an issue with the app itself

@CR96 CR96 marked this pull request as ready for review October 24, 2020 16:54
@CR96 CR96 changed the title [WIP] OFA-415: Add accessible labels to buttons on Officer Profile screen OFA-415: Add accessible labels to buttons on Officer Profile screen Oct 24, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 26, 2020

Hi @CR96 - we have been translating by hand, but getting the translations from native speakers.

And yes, the CI build is a pretty annoying and silly bug - it's in the github-provided action that we installed (and didn't change from the default!) that gives an extra nice welcome if this is the first commit you've done to the repository. So it's not worrisome at all.

@Sheeri Sheeri merged commit 3e9c896 into WildAid:main Oct 26, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 26, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

edualonso added a commit that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accessible labels to buttons on Officer Profile screen
2 participants