Skip to content

238 vessel page should show unique home port names only #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antwonthegreat
Copy link
Contributor

Related Issue

Fixes #238

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)
  • Optional: Add any explanations here

  • Optional: Add any relevant screenshots here

@Sheeri Sheeri self-requested a review October 4, 2020 13:44
Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions as requested, code looks good.

Here's the test case, looking good:

Screen Shot 2020-10-04 at 9 43 53 AM

More examples: with duplicates for the vessels Gin Palace, HMS Jolly, HMS Mongo, Happy Days; and multiple empty strings for HMS Roger:
Screen Shot 2020-10-04 at 9 46 33 AM

and in this build, they're all fixed:
Screen Shot 2020-10-04 at 9 47 49 AM

@Sheeri Sheeri merged commit 5a4fe43 into WildAid:main Oct 4, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 4, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vessel page should show unique home port names only
2 participants