Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #324: Improve phrasing for "You Might Not Need Redux" mention #325

Merged
merged 1 commit into from Oct 20, 2020

Conversation

stennie
Copy link
Contributor

@stennie stennie commented Oct 17, 2020

  • improve lead-in to "You Might Not Need Redux"
  • remove unnecessary <BR>s
  • add missing indent for code snippet

Fixes #324

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)
  • Optional: Add any explanations here

Straightforward Markdown changes, but I'm following the steps in the O-FISH Contributor guide :).

 - improve lead-in to "You Might Not Need Redux"
 - remove unnecessary <BR>s
 - add missing indent for code snippet
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your first PR to this repository. We appreciate your contribution! Our team will review your code within 3 business days. We <3 open source and are so glad you do, too!

@Sheeri
Copy link
Collaborator

Sheeri commented Oct 20, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

@Sheeri Sheeri merged commit 77df187 into WildAid:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: Improve phrasing for "You Might Not Need Redux" mention
2 participants