Use name where licence number isn't present

[ayushjainrksh]

Related Issue

Fixes #322

Approach

Check for captain name if captain licence isn't present to identify the crew is a captain and send the respective name to search for data.

Checklist:

• I have read the contributor's guide.
• I linked an issue in the previous section
• I have commented on the linked issue
• I was assigned the linked issue (not required)
• I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

• My change adds new text and requires a change to translations.
• My change requires a change to the documentation.
• I have submitted a PR to the documentation repo.
• I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
• This change depends O-FISH Realm repository changes (explain below)

[github-actions]

Thanks for submitting your first PR to this repository. We appreciate your contribution! Our team will review your code within 3 business days. We <3 open source and are so glad you do, too!

[ayushjainrksh]

The dataHelper functions find data using name when licence number is absent.

o-fish-web/src/components/partials/boarding-data.helper.js

Lines 205 to 213 in 14fbb74

	getCaptainName(item) {
	let captainName;
	this.boardings.forEach((boarding) => {
	if (boarding.captain.license === item || boarding.captain.name === item) {
	captainName = boarding.captain.name;
	}
	});
	return captainName;
	}

[Sheeri]

I couldn't get this to display information when there was a crew member with a name but no license. e.g. http://localhost:3000/#/crew/view/{%22crew.name%22:%22Stowaway%22} (where I had a crew member named 'Stowaway' with no license number.

[ayushjainrksh]

Earlier I missed out the crew name function. This is fixed now.

[ayushjainrksh]

@Sheeri It should be working now.

[Sheeri]

This looks great! Thanks.

[Sheeri]

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.