Skip to content

Now it pass the Web Accessibility Checker test #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Now it pass the Web Accessibility Checker test #57

merged 1 commit into from
Oct 6, 2020

Conversation

saribricka
Copy link
Contributor

Fixed Issue (Some I remember)

  • Readable: Make text content readable and understandable.

  • Input Assistance: Help users avoid and correct mistakes.

  • Text Alternatives: Provide text alternatives for any non-text content

Now for https://achecker.ca/checker/index.php there are no known problems

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your first PR to this repository. We appreciate your contribution! Our team will review your code within 3 business days. We <3 open source and are so glad you do, too!

Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is FANTASTIC. I am so glad that you raised this as an issue. Accessibility is SO important.

ALT tags should describe the image being shown, but not be too long.

alt='fork' doesn't really describe the image well - is it a picture of a piece of silverware? Imagine you are a comic book writer and trying to describe the image to an illustrator. e.g. "github code repo page with a red arrow pointing to the 'Fork' button". You don't need to say "in the upper-right-hand corner" because that's already in the text, so it's redundant.

Similarly, "add new developer agency" is an OK description of the page - it's the title of the page - but imagine all you see is the code, like we see in this review - it doesn't tell us much. Something like "alt=The Add New Developer Agency page, which has several fields to fill out".

Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment for changes!

Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment - the _layouts/default.html page is directly from the Just The Docs project - I am happy to accept this code change, and I recommend you also submit it to: https://github.com/pmarsceill/just-the-docs/blob/master/_layouts/default.html

@Sheeri
Copy link
Collaborator

Sheeri commented Oct 2, 2020

This PR prompted me to add a short explanation of alt-tags with examples at https://wildaid.github.io/style/2020/10/02/Alt-Text.html - it might be helpful if you're stuck on a description.

Thanks for sparking this! Really excellent stuff.

@Sheeri Sheeri merged commit 8aa1729 into WildAid:master Oct 6, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 19, 2020

Hi @saribricka!
We noticed you haven't gotten your MongoDB digital swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants