New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting 'count-trailing-zeros' and 'count_one_bits' to Rust #195

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
3 participants
@DavidDeSimone
Collaborator

DavidDeSimone commented May 29, 2017

This PR will allow us to delete:

lib/count-one-bits.c
lib/count-one-bits.h
lib/count-trailing-zeros.c
lib/count-trailing-zeros.h

By replacing the functionality provided in these files by function provided by the Rust standard library.

I will submit the deletion of those files as a separate PR, as it looks like people (including myself!) have been removing files from lib/ without running gnulib-tool to re-generate the make files. Running gnulib-tool now with the proper generation command leads to some slightly incorrect makefiles, and that will need to be corrected.

@@ -0,0 +1,22 @@
extern crate libc;

This comment has been minimized.

@jeandudey

jeandudey May 29, 2017

Collaborator

I think this should be on the crate root and import it in submodules with use libc;

@jeandudey

Aside from that minor note, everything is ok 💯 . Let me know what do you think or if you change it to merge this.

@DavidDeSimone

This comment has been minimized.

Collaborator

DavidDeSimone commented May 30, 2017

@jeandudey Thanks for the feedback, I've updated the PR.

@jeandudey jeandudey merged commit 6660b4e into Wilfred:master May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Wilfred

This comment has been minimized.

Owner

Wilfred commented May 30, 2017

Nice!

I will submit the deletion of those files as a separate PR, as it looks like people (including myself!) have been removing files from lib/ without running gnulib-tool to re-generate the make files

I wonder if we can configure Travis to make sure we don't forget in future. I think I'm guilty of this too.

@DavidDeSimone DavidDeSimone deleted the DavidDeSimone:count-zeros branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment