New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multibyte-string-p to rust #211

Merged
merged 3 commits into from Jun 20, 2017

Conversation

Projects
None yet
3 participants
@shanavas786
Collaborator

shanavas786 commented Jun 19, 2017

No description provided.

#[lisp_fn]
fn multibyte_string_p(object: LispObject) -> LispObject {
LispObject::from_bool(
object.is_string() && object.as_string_or_error().is_multibyte(),

This comment has been minimized.

@birkenfeld

birkenfeld Jun 19, 2017

Collaborator

Better: object.as_string().map_or(false, |s| s.is_multibyte())

@shanavas786

This comment has been minimized.

Collaborator

shanavas786 commented Jun 20, 2017

@birkenfeld Thanks, updated

@Wilfred

Looks good to me! :)

@Wilfred Wilfred merged commit b2e558e into Wilfred:master Jun 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Wilfred

This comment has been minimized.

Owner

Wilfred commented Jun 20, 2017

Thanks.

@shanavas786 shanavas786 deleted the shanavas786:multibyte-string-p branch Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment