New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved vector functions into rust #213

Merged
merged 10 commits into from Jun 21, 2017

Conversation

Projects
None yet
3 participants
@mjfeller
Contributor

mjfeller commented Jun 20, 2017

I've recreated this PR with a fresh branch from the master. Everything should be implemented and good to go.

Let me know if there is anything I've missed or can clean up. I'm still very new to Rust and Remacs

self.is_cons() || self.is_nil() || self.is_array()
}
pub fn is_configuration(self) -> bool {

This comment has been minimized.

@birkenfeld

birkenfeld Jun 20, 2017

Collaborator

I'd prefer is_window_configuration, even if it's long, for clarity.

}
pub fn is_array(self) -> bool {
self.is_vector() || self.is_string() || self.is_char_table() || self.is_bool_vector()

This comment has been minimized.

@birkenfeld

birkenfeld Jun 20, 2017

Collaborator

This could be made more efficient by only matching once for is_vectorlike, and then ORing the subtype checks.

But it's probably not worth the slightly smaller readability, or even optimized away in release.

This comment has been minimized.

@mjfeller

mjfeller Jun 20, 2017

Contributor

I'll leave it as is for now unless someone says it should be changed.

I have no preference. As long as there's a comment it's fine either way.

@Wilfred

Lovely! Looks good to me, and some useful LispObject methods for future primitive porting.

@birkenfeld birkenfeld merged commit f21cfc1 into Wilfred:master Jun 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shanavas786 shanavas786 referenced this pull request Jun 21, 2017

Closed

Port vectorp to rust #212

@birkenfeld birkenfeld referenced this pull request Jul 15, 2017

Closed

Port subrp to Rust #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment