New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port overlayp and buffer-live-p to rust #215

Merged
merged 4 commits into from Jun 24, 2017

Conversation

Projects
None yet
3 participants
@shanavas786
Collaborator

shanavas786 commented Jun 22, 2017

No description provided.

shanavas786 added some commits Jun 22, 2017

@shanavas786 shanavas786 changed the title from Port overlayp to rust to Port overlayp and buffer-live-p to rust Jun 22, 2017

@birkenfeld

This comment has been minimized.

Collaborator

birkenfeld commented Jun 22, 2017

Looks good, just needs a cargo fmt

@birkenfeld

This comment has been minimized.

Collaborator

birkenfeld commented Jun 23, 2017

Thanks! The remaining failure is because some test is looking for the buffer-live-p defun in C. We can just point it to another defun for now.

@shanavas786

This comment has been minimized.

Collaborator

shanavas786 commented Jun 23, 2017

Exporting Fbuffer_live_p is not enough ?

How can we point it to another defun ?

Got it, pointed it to buffer-list

Fix failing tests
search for definition of `buffer-list` instead of `buffer-live-p` as the later is already ported to rust

@Wilfred Wilfred merged commit 85a2137 into Wilfred:master Jun 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Wilfred

This comment has been minimized.

Owner

Wilfred commented Jun 24, 2017

Looks great, thank you :)

@shanavas786 shanavas786 deleted the shanavas786:port-overlayp branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment