New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented process-name #341

Merged
merged 4 commits into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@Yarikx
Collaborator

Yarikx commented Oct 2, 2017

Closes #331

Yarikx added some commits Oct 2, 2017

@@ -736,6 +736,8 @@ pub struct Lisp_Char_Table {
#[repr(C)]
pub struct Lisp_Process {
pub header: Lisp_Vectorlike_Header,

This comment has been minimized.

@birkenfeld

birkenfeld Oct 4, 2017

Collaborator

So... nobody was using the members before?

This comment has been minimized.

@Yarikx

Yarikx Oct 4, 2017

Collaborator

Apparently. I was getting tty_name instead of name there.

/// Return t if OBJECT is a process.
#[lisp_fn]
pub fn processp(object: LispObject) -> LispObject {
LispObject::from_bool(object.is_process())
return LispObject::from_bool(object.is_process());

This comment has been minimized.

@birkenfeld

birkenfeld Oct 4, 2017

Collaborator

unnecessary (and unidiomatic) change, please revert

This comment has been minimized.

@Yarikx

Yarikx Oct 4, 2017

Collaborator

Added it because of failing build on Travis. I don't like that return either.

impl LispProcessRef {
#[inline]
fn name(&self) -> LispObject {
return LispObject::from_raw(self.name);

This comment has been minimized.

@birkenfeld

birkenfeld Oct 4, 2017

Collaborator

return can be removed here too

@brotzeit brotzeit merged commit a9b826d into Wilfred:master Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment