New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: global options for specific servers #132

Closed
hart323 opened this Issue Jul 17, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@hart323
Contributor

hart323 commented Jul 17, 2014

I have configuraton with views.
I added 2 options for 1 server:
notify-source
transfer-source

but when I try to build config those options does not get into config. But when I try to move them to options for one of the views -> config generated with those options.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Jul 17, 2014

A fix is already in place for v1.3.

@WillyXJ WillyXJ closed this Jul 17, 2014

@hart323

This comment has been minimized.

Contributor

hart323 commented Jul 18, 2014

Tried 1.3 version. It has the same type of bug.
Fix:

class_buildconf.php line 253

was:
$server_config[$server_config_result0->cfg_name] = @array($server_config_result0->cfg_data, $config_result[$i]->cfg_comment);
now:
$server_config[$server_config_result[$j]->cfg_name] = @array($server_config_result[$j]->cfg_data, $config_result[$i]->cfg_comment);

WillyXJ added a commit that referenced this issue Jul 18, 2014

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Jul 18, 2014

Hrm. Odd that I couldn't reproduce it, but I do see in that line how it would cause problems. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment