New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudomains with _ #143

Closed
wispr opened this Issue Jul 29, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@wispr

wispr commented Jul 29, 2014

GUI cannot create a subdomain that starts with an underscore, in this case _msdcs which is required for Active Directory. It appears to validate the input but after hitting submit, it does not commit the record.

@wispr

This comment has been minimized.

wispr commented Jul 29, 2014

also, unable to add an A record similar to this: "89a9d92d-0000-0000-9055-30fd10b02aaa._msdcs" which is a hashed value of a domain controller that needs an A record. Can't create the subdomain of _msdcs but appear to be able to add some types of _msdcs records to the main tld.

@wispr

This comment has been minimized.

wispr commented Aug 4, 2014

Jon, any thoughts on the hash value needed for active directory to be happy?

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Aug 5, 2014

The record validation is being rewritten for 1.3, but if you don't want to wait (no targeted release date as of yet) then you can remove the underscore from https://github.com/WillyXJ/facileManager/blob/master/server/fm-modules/fmDNS/pages/zone-records-validate.php#L583 in your environment. This will always allow an underscore in a name which I don't think is always valid if I remember correctly.

@wispr

This comment has been minimized.

wispr commented Aug 5, 2014

Jon, I believe you are correct. Specifically, underscores are not allowed in hostnames. However, they are allowed in domain names. In this example, the hostname should be 89a9d92d-0000-0000-9055-30fd10b02aaa (all valid characters) and the zone should be .msdcs.domain.com but the validation is broken on the zone creation. You can attempt to create the .,msdcs subzone, click validate, and it will simply take you back to to main domain page. Short term, the workaround is to remove the underscore. Long term, subzones/domains need to allow _ in them which is in the RFC spec.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Aug 5, 2014

That is correct. The real fix will be in the regex of https://github.com/WillyXJ/facileManager/blob/master/server/fm-modules/fmDNS/classes/class_zones.php#L997 to properly allow the underscore.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Aug 15, 2014

Updated zone name validation regex to properly support underscore.

@WillyXJ WillyXJ closed this Aug 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment