Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward only | forward first #168

Closed
lgallard opened this issue Jan 6, 2015 · 5 comments
Closed

forward only | forward first #168

lgallard opened this issue Jan 6, 2015 · 5 comments

Comments

@lgallard
Copy link

@lgallard lgallard commented Jan 6, 2015

Hi WillyXJ,

We are using facileManager for DNS purposes and we ran into a missing option in zone definition: forward only / forward first. As explained here http://www.zytrax.com/books/dns/ch7/queries.html#forward, if set to 'only' the server will only forward queries, if set to 'first' (default) it will send the queries to the forwarder and if not answered will attempt to answer the query.This statement may be used in a zone, view or a global options clause.

Although on facileManager you can set the forward option in view and options, there's no way to set it in zone. There should be a dropdown to choose between only and first when defining the zone as forward.

In our case we needed to use a forward only, so we solved the issue by changing this line in file classes/class_buildconf.php:

case 'forward':
$zones .= "\tforwarders { " . $zone_result[$i]->domain_forward_servers . "};\n";

We added this:

case 'forward':
// Added "\tforward only;\n" to force forward only behavior
$zones .= "\tforward only;\n\tforwarders { " . $zone_result[$i]->domain_forward_servers . "};\n";

But it would be nice to have the option when defining a zone of type forward.

Best regards!

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Jan 6, 2015

Nice oversight you've found, lgallard. Thank you for reporting it and I'll try to get 1.3.5 out with the fix. If not, it will at least be a part of 2.0.

Loading

@lgallard
Copy link
Author

@lgallard lgallard commented Jan 7, 2015

Thanks you for the project. I wanted to implement it myself and make a pull request, but I'm not clear about how you safe zone definitions (I assume representing an object "zone" in the database").

Best regards!

Loading

WillyXJ added a commit that referenced this issue Jan 7, 2015
forward first | forward only now supported in zone definitions
@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Jan 7, 2015

This fix has been added to v1.3.5 which will be released in the next day or two.

Loading

@WillyXJ WillyXJ closed this Jan 7, 2015
@lgallard
Copy link
Author

@lgallard lgallard commented Jan 7, 2015

I really appreciate it. One more time, thanks!

Loading

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Jan 7, 2015

You're welcome - I'm glad you find it useful.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants