Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
PHP Versions/Other Bugs (2.0.1) #212
There are a number of bugs I'd like to bring up. I can create a new issue for each one if required.
Firstly I need to say that I'm in no way putting down fmDNS. It's fantastic and simply the best thing out there today. I have not seen any reports of what I'm going to mention, so this is a FYI.
I'm not sure if any testing has been done on PHP 5.6.7 or not, I ran into several issues that I believe are in direct relation to the PHP version changes.
(minor notes below, may not be broken)
pushed a commit
May 13, 2015
added a commit
May 13, 2015
While I wasn't able to reproduce the client version compare with a FreeBSD 10.1, BIND 9.9.7, and PHP 5.6.8 test environment, I see how it could fail. A fix has been submitted for the upcoming bug fix release and you're welcome to confirm the changes before the release by manually applying the fix (abc321c).
Negative, but I can help ... just found the issue.
The version_compare will work fine with text after the actual version.
The client of course prunes off BIND with sed(1), leaving just: 9.9.7 (Extended Support Version)
So, "9.9.7 (Extended Support Version)" is sent to the server. The function validateDaemonVersion was never being hit. The change to the clients functions.php from buildconf to buildconf.php probably was still needed (haven't tested this part).
The fix: Remove the prefixing "/" character before buildconf.php in your patch.
I think this was throwing off the index path (or what have you, I'm not a PHP person) in fm-init.php on the server side.
Once that prefixed slash was gone, clients can be installed.
Side note: Since FreeBSD 10, named is no longer shipped with it. You won't find the named startup script in /etc/rc.d anymore. If it's installed from the ports (I suspect most people do this) you'll want:
functions.php for fmDNS on the client side, this line:
'FreeBSD' => '/etc/rc.d/named start',
Should be replaced with:
'FreeBSD' => '/usr/local/etc/rc.d/named start',