New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to add include statement to named.conf #301

Closed
peterschen opened this Issue Mar 31, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@peterschen
Contributor

peterschen commented Mar 31, 2016

Sometimes it is handy to have the possibility to include a custom zone file for a nameserver when certain options are not available or feasible through fmDNS. I can add include within the options for a nameserver but this excludes the use of zone and all other statements which are not allowed within options

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Mar 31, 2016

include support in the zone configs was added in v2.1 (#123) and then fixed in v2.1.4 (#270). However, #271 shows one report where it still does not work. Are you having a similar issue?

@peterschen

This comment has been minimized.

Contributor

peterschen commented Mar 31, 2016

I want to have the include in named.conf and not in the options or zone statements. I found no way to make this happen. For now I hacked the buildconfig process to have this for a particular server. But this is not the way would like this.

@WillyXJ WillyXJ added this to the 3.0 release milestone Mar 31, 2016

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Mar 31, 2016

I understand now you want include in named.conf, but not in the options, view, and zone clauses. I remember looking at supporting that with #123, but could not come up with a good implementation at the time. Leaving this open to revisit it.

@WillyXJ WillyXJ modified the milestones: 2.x release, 3.0 release Apr 1, 2016

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Apr 1, 2016

Found a solution and this can be included in the next release.

image

@peterschen

This comment has been minimized.

Contributor

peterschen commented Apr 1, 2016

I like it.

A more forward looking solution might be to have a third tab within the options: one for named.conf (include and whatnot), one for options {} and one for rate limiting. This would an extensible solution in the future.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Apr 1, 2016

That's an interesting and good suggestion. However, I don't know of any other entries in named.conf that would not be include or a clause thus that tab would have nothing but include statements listed. I could be wrong though.

WillyXJ added a commit that referenced this issue Apr 1, 2016

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Apr 25, 2016

v2.2 has been released and contains this improvement.

@WillyXJ WillyXJ closed this Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment