New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fmDNS: Don't work feature - support proxy-server #399

Closed
beza2000 opened this Issue Oct 18, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@beza2000

beza2000 commented Oct 18, 2017

fM Version : 3.0.3
fmDNS Version : 3.0.4

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
If I use the option of proxy server,
fmDNS can download named.root from http://www.internic.net/domain/named.root

(BUG | ISSUE) Actual Behavior:
fmDNS doesn't download file and uses named.root from local copy.
From my squid.log:

1508324979.759      0 x.x.x.x TAG_NONE/400 3957 GET /domain/named.root - HIER_NONE/- text/html
1508324980.196      0 x.x.x.x TAG_NONE/400 3957 GET /domain/named.root - HIER_NONE/- text/html

If I change code and use 'request_fulluri' => true, fmDNS works.

diff -Naur facileManagerControl/server/fm-modules/fmDNS/classes/class_buildconf.php facileManager/server/fm-modules/fmDNS/classes/class_buildconf.php
--- facileManagerControl/server/fm-modules/fmDNS/classes/class_buildconf.php    2017-10-11 04:51:06.000000000 +0300
+++ facileManager/server/fm-modules/fmDNS/classes/class_buildconf.php   2017-10-18 14:24:34.774991669 +0300
@@ -1459,6 +1459,7 @@
                if (getOption('proxy_enable')) {
                        $default_opts = array(
                                'http' => array(
+                                       'request_fulluri' => true,
                                        'method' => 'GET',
                                        'proxy' => 'tcp://' . getOption('proxy_host') . ':' . getOption('proxy_port')
                                )
@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Oct 18, 2017

Would you please submit a pull request with this code change?

@beza2000

This comment has been minimized.

beza2000 commented Oct 20, 2017

I made the pull request - #400

WillyXJ added a commit that referenced this issue Nov 2, 2017

Merge pull request #400 from beza2000/fmDNS_proxy_patch
Issue #399 Add option 'request_fulluri' for proxy server

WillyXJ pushed a commit that referenced this issue Nov 2, 2017

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 14, 2017

This is now fixed in fmDNS 3.1 and later.

@WillyXJ WillyXJ closed this Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment