New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error in fmDNS/upgrade.php #404

Closed
gianlucagiacometti opened this Issue Dec 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@gianlucagiacometti

gianlucagiacometti commented Dec 14, 2017

fM Version : 3.1
{Module Name} Version : fmDNS

In raising this issue, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
Upgrade of fmDNS schema OK

(BUG | ISSUE) Actual Behavior:
Upgrade of fmDNS fails

(BUG | ISSUE) Steps to reproduce:
Upgrade from version 3.0.4

{replace this line with your issue content}

There a missed comma in the SQL code in server/fm-modules/fmDNS/upgrade.php
group_status enum('active','disabled','deleted') NOT NULL
should be
group_status enum('active','disabled','deleted') NOT NULL,

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 14, 2017

Well, that's embarrassing! Thanks for the quick report and this is now fixed in fmDNS 3.1.1 and later. You will most likely need to restore your DB back to 3.0.4 before upgrading to 3.1.1 now.

@WillyXJ WillyXJ closed this Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment