New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Create/update PTR from forward zone seems broken for some IP addresses #408

Closed
mdklapwijk opened this Issue Mar 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mdklapwijk

mdklapwijk commented Mar 2, 2018

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 3.1.1
fmDNS Version : 3.1.2

In raising this issue, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
Exempt from log for forward:
Updated a record (test) with the following details:
Domain: domain.com
Type: A
Name: test
Class: IN
Type: A
Value: 10.1.7.177
Status: active

Exempt from log for reverse:
Updated a record (177.1) with the following details:
Domain: 10.in-addr.arpa
Type: PTR
Name: 177.7.1
Class: IN
Value: test.domain.com.
Status: active
Domain Id: 12

(BUG | ISSUE) Actual Behavior:
Exempt from log for forward:
Added a record with the following details:
Domain: domain.com
Type: A
Name: test
Class: IN
Value: 10.1.10.177
Status: active

Exempt from log for reverse:
Added a record with the following details:
Domain: 10.in-addr.arpa
Type: PTR
Name: 177.1
Class: IN
Value: test.domain.com.
Status: active

(BUG | ISSUE) Steps to reproduce:
Just create an a-record with PTR enabled:

  • 10.1.7.177 works ok,
  • 10.1.10.177 drops the 10 in the third octed.

There seems to be an issue with the creation and updating of reverse/PTR records from the forward zone, the reverse entry ends up being incomplete and missing part of the address.

@mdklapwijk

This comment has been minimized.

mdklapwijk commented Mar 2, 2018

Willy, normally I would check the code myself for a fix, but am currently not able to, sorry!

@mdklapwijk

This comment has been minimized.

mdklapwijk commented Mar 2, 2018

Maybe a regex that removes the first octet from, but is set to 'greedy' and removes every instance of that value? So something like:
s/10\.//g

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Oct 26, 2018

This is now fixed in fmDNS 3.2 and later.

@WillyXJ WillyXJ closed this Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment