New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP Peer: load balance max seconds #424

Closed
cm91 opened this Issue Dec 15, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@cm91
Copy link

cm91 commented Dec 15, 2018

Please prefix your issue title with one of the following: [BUG]

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 3.3
{fmDHCP} Version : 0.3

In raising this issue, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG) Expected Behavior:

In DHCP Peer declaration there is a parameter for load balance max seconds.
The parameter should be "load balance max seconds"

(BUG | ISSUE) Actual Behavior:

In fmDHCP the parameter is "load balance max secs"
isc-dhcp does not understand that and fails.

@WillyXJ

This comment has been minimized.

Copy link
Owner

WillyXJ commented Dec 15, 2018

This is now fixed in fmDHCP 0.3.1 and later. Although, it may crop up because I think ISC changed the option between versions at some point. I have yet to figure out which version though.

@WillyXJ WillyXJ closed this Dec 15, 2018

@cm91

This comment has been minimized.

Copy link

cm91 commented Dec 16, 2018

The parameter now gets created with underscores: load_balance_max_seconds 3;

@WillyXJ WillyXJ reopened this Dec 16, 2018

WillyXJ pushed a commit that referenced this issue Dec 16, 2018

@WillyXJ

This comment has been minimized.

Copy link
Owner

WillyXJ commented Dec 16, 2018

This is now fixed in fmDHCP 0.3.2 and later. For real this time. :)

@WillyXJ WillyXJ closed this Dec 16, 2018

@cm91

This comment has been minimized.

Copy link

cm91 commented Dec 16, 2018

Thanks so much, now it works :)
Can you please tell me, how you fixed that? I tried to fix that by myself in an earlier version but always got stuck on that underscore issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment