Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]Failed to write out "forwarders{ };" in the "zone.conf" files #443

Closed
ReiAyaya opened this issue May 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ReiAyaya
Copy link

commented May 13, 2019

Please prefix your issue title with one of the following: [BUG], [ISSUE], [FEATURE REQUEST], [MODULE REQUEST], [OTHER].

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 3.4.1
{Module Name} Version : fmDNS 3.3.3

In raising this issue, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
When specified no forwarder in the zones section, "zone.conf" files write out "forwarders{ };" code.

(BUG | ISSUE) Actual Behavior:
When setting Zones Options, failed to write out empty forwarders as "forwarders{ };" for "type master" in "zones.conf" files.

(BUG | ISSUE) Steps to reproduce:
Input an empty value in "Option Value" text box on "Add Option" dialog box.
But displayed disallowed message.
So tried to input like this comment "/empty/" instead empty value in "Option Value".
Although, can not write out it.

I already know # 299 and # 324, but I still looks like the same thing is happening.
Please check once.

@WillyXJ

This comment has been minimized.

Copy link
Owner

commented May 17, 2019

This is now fixed in fmDNS 3.3.4 and later.

@WillyXJ WillyXJ closed this May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.