Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fmDNS issue with PHP 7.3 on Debian 10 #454

Closed
jisse44 opened this issue Aug 19, 2019 · 2 comments

Comments

@jisse44
Copy link

commented Aug 19, 2019

fM Version : 3.4.2
fmDNS Version : 3.3.4

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
When adding a new A record, zone file is generated by cron

(BUG | ISSUE) Actual Behavior:
A PHP fatal error occurs

(BUG | ISSUE) Steps to reproduce:
Add new A record, run cron:
/usr/bin/php /usr/local/facileManager/fmDNS/client.php cron

OS: Debian 9 upgraded to Debian 10
PHP version: PHP 7.3 (PHP 7.3.4-2 from Debian 10 packages)

Error:
PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function fm_module_buildconf::buildZoneFile(), 1 passed in /var/www/fm-modules/fmDNS/classes/class_buildconf.php on line 1020 and exactly 2 expected in /var/www/fm-modules/fmDNS/classes/class_buildconf.php:921\nStack trace:\n#0 /var/www/fm-modules/fmDNS/classes/class_buildconf.php(1020): fm_module_buildconf->buildZoneFile(Object(stdClass))\n#1 /var/www/fm-modules/shared/pages/buildconf.php(58): fm_module_buildconf->buildCronConfigs(Array)\n#2 /var/www/index.php(51): include('/var/www/fm-mod...')\n#3 {main}\n thrown in /var/www/fm-modules/fmDNS/classes/class_buildconf.php on line 921

@jisse44

This comment has been minimized.

Copy link
Author

commented Aug 19, 2019

When I downgrade PHP to 7.0 (via PHP Sury packages), it works again

@WillyXJ

This comment has been minimized.

Copy link
Owner

commented Oct 2, 2019

This is now fixed in fmDNS 3.4 and later.

@WillyXJ WillyXJ closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.