Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] rename zone files #456

Closed
bstall23 opened this issue Aug 29, 2019 · 6 comments
Closed

[FEATURE REQUEST] rename zone files #456

bstall23 opened this issue Aug 29, 2019 · 6 comments

Comments

@bstall23
Copy link

@bstall23 bstall23 commented Aug 29, 2019

fmDNS creates zone files as 'db.example.com.hosts.'

I would like to know if there is a way to change the hard coded way fmDNS names its zone files?

The reason for this is so zone files from fmDNS meets the standardized naming scheme already in place at work The way it is named at work is "example.com.zone"

Any help would be appreciated

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Aug 30, 2019

Zone file names are not changeable without changing it in the code. Of course, if you do that, then any upgrades will wipe out your changes.

@bstall23
Copy link
Author

@bstall23 bstall23 commented Aug 30, 2019

@WillyXJ WillyXJ changed the title [ISSUE] how do you rename zone files [FEATURE REQUEST] rename zone files Aug 30, 2019
@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Aug 30, 2019

I'll change this to a feature request for the zone file names to be configurable.

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Oct 2, 2019

This is now fixed in fmDNS 3.4 and later.

@susanin-ivan
Copy link

@susanin-ivan susanin-ivan commented Feb 17, 2021

Hi,

It looks like this change introduced file naming bug - if default_value is 'db.{ZONENAME}.hosts', then slave zone file names become:

Old: file "/etc/named/zones/slave/db.0.0.20.in-addr.arpa.0.rev";
New: file "/etc/named/zones/slave/db.0.0.20.in-addr.arpa0..hosts";

Old: file "/etc/named/zones/slave/db.zone.com.0.hosts";
New: file "/etc/named/zones/slave/db.zone.com0..hosts";

Master and Stub zones naming is not affected:

Old: file "/etc/named/zones/master/db.0.0.127.in-addr.arpa.rev";
New: file "/etc/named/zones/master/db.0.0.127.in-addr.arpa.hosts";

Old: file "/etc/named/zones/stub/db.1.100.100.in-addr.arpa.rev";
New: file "/etc/named/zones/stub/db.1.100.100.in-addr.arpa.hosts";

Fix for me was to change in class_buildconf.php line 886:

$file_ext = $view_id . ".$default_file_ext";

to become:

$file_ext = '.' . $view_id . "$default_file_ext";

I've added comment regarding it in your change:

e43bd22#r47217956

Thank you!

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Feb 18, 2021

@susanin-ivan Confirmed and fixed in next release.

WillyXJ pushed a commit that referenced this issue Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants