New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh installation - no population of fm_dns_options table #55

Closed
msenebald opened this Issue Dec 23, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@msenebald

msenebald commented Dec 23, 2013

Hi,

i installed on a fresh centos 6.5 with:
php 5.3.3
mysql 5.1.71

an facileManager full package
everything worked as expected except the option table for dns was not populated.
Uninstall / Install of module dns didnt help either.
Then i tried a clone from master branch, and it didnt fix it.

i am happy to provide more infos to investigate.
Any idea would be helpful.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 24, 2013

Hi,

The fm_dns_options table isn't supposed to be populated upon installation. This table holds the module options (settings) such as whether or not to run named-checkconf prior to config builds.

Is a fresh installation not working for you?

@msenebald

This comment has been minimized.

msenebald commented Dec 24, 2013

Hi,

oh really?
The problem i am facing, for new views i create, there are no options in the dropdown, when create a new option.
I checked how it supposed to be on the demo. Going through your code i realised that one table should hold the available options to pick from or?. https://github.com/WillyXJ/facileManager/blob/master/server/fm-modules/fmDNS/install.php#L308
I double checked. Should it be then in fm_dns_functions? that hold these available options?
This is empty as well.

Or am i missing something else? Everything seems to work except i cant create proper view options bcos the dropdown (option name) on create view option is empty.

@msenebald

This comment has been minimized.

msenebald commented Dec 24, 2013

Hi,
i think i found the problem.

the sql statement is not running in the install.php
there are some columns to much on some lines or a field missing in the header.

example:
https://github.com/WillyXJ/facileManager/blob/master/server/fm-modules/fmDNS/install.php#L357
compared to
https://github.com/WillyXJ/facileManager/blob/master/server/fm-modules/fmDNS/install.php#L333

I dont know whichs combinations (yes or no) are correct, but i just removed any 6th value and the query runs, and the options show in the views add option menu.

i can provide the query i used. but i guess a dump of the table would be easier.

br Martin

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 24, 2013

Ok, that's a major bug there. The install script didn't create the proper table structure for fm_dns_functions. I've submitted the fix and it will go out in 1.0.1. You can grab it from master if you'd like to test it and get your system going.

Sorry about that one!

WillyXJ pushed a commit that referenced this issue Dec 24, 2013

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 24, 2013

Resolved in fmDNS v1.0.1.

@WillyXJ WillyXJ closed this Dec 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment