BCMenu.cpp: Fix memory leak

sdottaka · sdottaka · commit 6fa585fd62e9 · 2024-07-04T08:14:26.000+09:00
diff --git a/Src/Common/BCMenu.cpp b/Src/Common/BCMenu.cpp
@@ -230,7 +230,9 @@ void BCMenuData::SetWideString(const wchar_t *szWideString)
 void BCMenu::DisableOwnerDraw()
 {
 	m_bEnableOwnerDraw = false;
-	afxData.hbmMenuDot = reinterpret_cast<HBITMAP>(CreateRadioDotBitmap()->Detach());
+	CBitmap* pBitmap = CreateRadioDotBitmap();
+	afxData.hbmMenuDot = reinterpret_cast<HBITMAP>(pBitmap->Detach());
+	delete pBitmap;
 }
 
 bool BCMenu::IsMenu(HMENU submenu)

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,9 @@ void BCMenuData::SetWideString(const wchar_t *szWideString)`
`230`	`230`	`void BCMenu::DisableOwnerDraw()`
`231`	`231`	`{`
`232`	`232`	`m_bEnableOwnerDraw = false;`
`233`		`- afxData.hbmMenuDot = reinterpret_cast<HBITMAP>(CreateRadioDotBitmap()->Detach());`
	`233`	`+ CBitmap* pBitmap = CreateRadioDotBitmap();`
	`234`	`+ afxData.hbmMenuDot = reinterpret_cast<HBITMAP>(pBitmap->Detach());`
	`235`	`+ delete pBitmap;`
`234`	`236`	`}`
`235`	`237`
`236`	`238`	`bool BCMenu::IsMenu(HMENU submenu)`