Add Support for Custom System Color Overrides#2376
Merged
Conversation
# Conflicts: # Src/BasicFlatStatusBar.cpp # Src/BasicFlatStatusBar.h # Src/MergeStatusBar.cpp
# Conflicts: # Src/Merge.vcxproj.filters
|
|
||
| CMenuBar(); | ||
|
|
||
| virtual BOOL Create(CWnd* pParentWnd, DWORD dwStyle = WS_CHILD | WS_VISIBLE | CBRS_ALIGN_TOP, UINT nID = AFX_IDW_MENUBAR); |
Check failure
Code scanning / CodeQL
Redefined default parameter
|
|
||
| CMenuBar(); | ||
|
|
||
| virtual BOOL Create(CWnd* pParentWnd, DWORD dwStyle = WS_CHILD | WS_VISIBLE | CBRS_ALIGN_TOP, UINT nID = AFX_IDW_MENUBAR); |
Check failure
Code scanning / CodeQL
Redefined default parameter
# Conflicts: # Src/MenuBar.cpp
Contributor
|
Do you think it will be possible to override scrollbar colours at some point? |
Member
Author
|
I think it's possible to make scrollbars color changeable, but it would require more work than other UI elements. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hooks the Windows system color retrieval function GetSysColor() to return customized colors. This allows you to change the color of toolbars, status bars, etc. as shown below. However, this only works in some areas and does not currently apply to dialog windows, scroll bars, etc.
You can customize the system colors in the Colors/System category of the Options window.