New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GearSwap issues #1668

Open
Iminiillusions opened this Issue Jun 7, 2018 · 15 comments

Comments

Projects
None yet
5 participants
@Iminiillusions

Iminiillusions commented Jun 7, 2018

Hello, I've had an issue since about 2 or 3 Windower updates ago where GearSwap equips my WS set when I use certain abilities like Reverse Flourish, Fan Dance, Saber Dance, Unbridled Learning, Warcry, Provoke, Cutting Cards, Flee, and Batatuta. I have spent countless hours beating my head thinking its something with the rules, but seeing how its Motenten's lua's which is what most people use, without issue, and it was working just fine before, I am at a complete loss as to what it could be.

Thanks for looking at this.

-Iminiillusions of Asura

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 7, 2018

here's an example of one of my LUAs that's this happens with.
DNC.zip

Iminiillusions commented Jun 7, 2018

here's an example of one of my LUAs that's this happens with.
DNC.zip

@Byrth

This comment has been minimized.

Show comment
Hide comment
@Byrth

Byrth Jun 10, 2018

Contributor

I think you might just need to capitalize "engaged" to "Engaged" in your set definitions.

Lua is case sensitive.

Contributor

Byrth commented Jun 10, 2018

I think you might just need to capitalize "engaged" to "Engaged" in your set definitions.

Lua is case sensitive.

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 11, 2018

Iminiillusions commented Jun 11, 2018

@Byrth

This comment has been minimized.

Show comment
Hide comment
@Byrth

Byrth Jun 14, 2018

Contributor

Unfortunately I really don't know. This is an issue related to the Motenten lib. He quit years ago and I don't support his files.

Contributor

Byrth commented Jun 14, 2018

Unfortunately I really don't know. This is an issue related to the Motenten lib. He quit years ago and I don't support his files.

@smd111

This comment has been minimized.

Show comment
Hide comment
@smd111

smd111 Jun 14, 2018

Contributor

just doing a quick look over the file you posted

  1. you have no sets in init_gear_sets for the JA's you posted about or they are commented out
  2. you have no rules in job_precast to do anything or they are commented out

in lua -- or --[[...]] is how you do comments
--comments out a single line
--[[comments out till you use]]

(mind you i know vary little about motes include but) this is what i see

Contributor

smd111 commented Jun 14, 2018

just doing a quick look over the file you posted

  1. you have no sets in init_gear_sets for the JA's you posted about or they are commented out
  2. you have no rules in job_precast to do anything or they are commented out

in lua -- or --[[...]] is how you do comments
--comments out a single line
--[[comments out till you use]]

(mind you i know vary little about motes include but) this is what i see

@zetaepyon

This comment has been minimized.

Show comment
Hide comment
@zetaepyon

zetaepyon Jun 14, 2018

Contributor

Have your lib files been modified in some way? I would try grabbing a clean copy of Mote's libs from:
https://github.com/Windower/Lua/tree/live/addons/GearSwap/libs

I don't see anything particularly wrong in that user file.

@smd111 With the default processing from Mote's libs you usually don't need to include specific rules for every ability, etc., so it's not that strange to see nothing in job_precast(). That function is simply called prior to the default precast() logic built into the library.

Contributor

zetaepyon commented Jun 14, 2018

Have your lib files been modified in some way? I would try grabbing a clean copy of Mote's libs from:
https://github.com/Windower/Lua/tree/live/addons/GearSwap/libs

I don't see anything particularly wrong in that user file.

@smd111 With the default processing from Mote's libs you usually don't need to include specific rules for every ability, etc., so it's not that strange to see nothing in job_precast(). That function is simply called prior to the default precast() logic built into the library.

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 14, 2018

Iminiillusions commented Jun 14, 2018

@smd111

This comment has been minimized.

Show comment
Hide comment
@smd111

smd111 Jun 14, 2018

Contributor

@zetaepyon
still of the ja's listed by Iminiillusions only Reverse Flourish and Saber Dance are in his sets and:
Reverse Flourish uses sets.precast.Flourish2['Reverse Flourish']--this might be correct i do not know

` sets.precast.Flourish2 = {}

sets.precast.Flourish2['Reverse Flourish'] = {hands="Charis Bangles +1"}`

Saber Dance is commented out so it will not equip any of the gear but it would only work during buff change
--sets.buff['Saber Dance'] = {legs="Horos Tights"}
so all the other ja's posted have no gear to equip

Contributor

smd111 commented Jun 14, 2018

@zetaepyon
still of the ja's listed by Iminiillusions only Reverse Flourish and Saber Dance are in his sets and:
Reverse Flourish uses sets.precast.Flourish2['Reverse Flourish']--this might be correct i do not know

` sets.precast.Flourish2 = {}

sets.precast.Flourish2['Reverse Flourish'] = {hands="Charis Bangles +1"}`

Saber Dance is commented out so it will not equip any of the gear but it would only work during buff change
--sets.buff['Saber Dance'] = {legs="Horos Tights"}
so all the other ja's posted have no gear to equip

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 14, 2018

Iminiillusions commented Jun 14, 2018

@smd111

This comment has been minimized.

Show comment
Hide comment
@smd111

smd111 Jun 14, 2018

Contributor

@Iminiillusions
why dont you just use
sets.precast.JA['Reverse Flourish'] = {hands="Charis Bangles +1"}
skip the spell.type info

Contributor

smd111 commented Jun 14, 2018

@Iminiillusions
why dont you just use
sets.precast.JA['Reverse Flourish'] = {hands="Charis Bangles +1"}
skip the spell.type info

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 14, 2018

Iminiillusions commented Jun 14, 2018

@zetaepyon

This comment has been minimized.

Show comment
Hide comment
@zetaepyon

zetaepyon Jun 14, 2018

Contributor

You're not really meant to put gear directly into sets.precast.Flourish2, that's a holding table for the specific Flourish II types. It may be a relic from when some timers needed to be created manually, but I'm not sure.

That said, I use this same base Lua for my own DNC, and don't have issues with it.

Contributor

zetaepyon commented Jun 14, 2018

You're not really meant to put gear directly into sets.precast.Flourish2, that's a holding table for the specific Flourish II types. It may be a relic from when some timers needed to be created manually, but I'm not sure.

That said, I use this same base Lua for my own DNC, and don't have issues with it.

@Iminiillusions

This comment has been minimized.

Show comment
Hide comment
@Iminiillusions

Iminiillusions Jun 14, 2018

Iminiillusions commented Jun 14, 2018

@Skyrant

This comment has been minimized.

Show comment
Hide comment
@Skyrant

Skyrant Jun 15, 2018

Contributor

sets.precast.Flourish2 and sets.precast.Flourish1 are not standard Motens tables. They are defined in your lua only using sets.precast.Flourish2 = {}.

You would need to write some code in job_precast() to equip them.

To assign a set to a specific spell or ability you should always use the basic Motens sets like: sets.precast['Waltz'] or sets.midcast['Waltz']

Contributor

Skyrant commented Jun 15, 2018

sets.precast.Flourish2 and sets.precast.Flourish1 are not standard Motens tables. They are defined in your lua only using sets.precast.Flourish2 = {}.

You would need to write some code in job_precast() to equip them.

To assign a set to a specific spell or ability you should always use the basic Motens sets like: sets.precast['Waltz'] or sets.midcast['Waltz']

@smd111

This comment has been minimized.

Show comment
Hide comment
@smd111

smd111 Jun 15, 2018

Contributor

actualy it does but it looks like something is wrong
Mote-Include.lua line 654: cat = (sets.precast[spell.type] and spell.type) or 'JA'
i think it should be: cat = (sets.precast[spell.type] and spell.type or 'JA')
im not sure who made this change but it weird that Mote would make this kind of mistake

Contributor

smd111 commented Jun 15, 2018

actualy it does but it looks like something is wrong
Mote-Include.lua line 654: cat = (sets.precast[spell.type] and spell.type) or 'JA'
i think it should be: cat = (sets.precast[spell.type] and spell.type or 'JA')
im not sure who made this change but it weird that Mote would make this kind of mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment