Remove widget references before removing it #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarranz
requested changes
Oct 27, 2016
| @@ -115,6 +115,20 @@ def test_remove_widget_from_workspace(self): | |||
| self.login(username="user_with_workspaces", next="/user_with_workspaces/Workspace") | |||
| self.find_widget(title="Test 1").remove() | |||
|
|
|||
| def test_remove_widget_from_workspace_with_behaviours(self): | |||
There was a problem hiding this comment.
Remove this selenium test and provide a unit test based on the current test_iwidget_removed test provided by the WiringTestCase class (wirecloud/platform/wiring/tests.py).
| @@ -22,7 +22,7 @@ | |||
| from django.utils.translation import ugettext as _ | |||
|
|
|||
| from wirecloud.commons.fields import JSONField | |||
| from wirecloud.platform.wiring.utils import remove_related_iwidget_connections | |||
There was a problem hiding this comment.
Take into account that this function is not used from a class, please, provide a more descriptive name (e.g. remove_widget_from_wiring_status or remove_related_widget_connections)
| @@ -29,38 +29,43 @@ | |||
| from wirecloud.platform.plugins import get_operator_api_extensions | |||
|
|
|||
|
|
|||
| def has_component(endpoint, component_id, component_type): | |||
| c_type, c_id, e_name = tuple(endpoint.split('/')) | |||
| def remove_component(component_type, component_id, wiring_status): | |||
There was a problem hiding this comment.
Why are implementing a generic remove_component if we are not removing operators?
jpajuelo
force-pushed
the
hotfix/issue-#248
branch
from
e4cc553
to
c4e6de3
Compare
jpajuelo
force-pushed
the
hotfix/issue-#248
branch
from
c88c3c5
to
7b1922b
Compare
aarranz
approved these changes
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits fix #248 and #250