feat: external-signer public uploads + single-chunk prepare/finalize across 15 SDKs#90
Merged
Conversation
Mirror the antd + antd-go reference impl for the new external-signer surfaces in the C++ SDK: - prepare_upload / prepare_data_upload gain an optional std::optional<std::string> visibility; prepare_upload_public is the convenience wrapper. - FinalizeUploadResult gains data_map and data_map_address (both parsed from the daemon's finalize response — data_map_address is set when prepare was called with visibility="public"). - New PrepareChunkResult struct + prepare_chunk_upload / finalize_chunk_upload on both Client and AsyncClient. - 6 doctest cases cover already-stored vs wave-batch branches, visibility forwarding (public / private / omitted), and data_map_address surfacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the new external-signer surfaces from the antd + antd-go reference impl: - Optional visibility on prepare-upload + a prepare-upload-public convenience wrapper. - data_map + data_map_address fields on the finalize-upload result (data_map_address is populated when prepare was called with visibility="public" — the DataMap chunk was bundled into the same external-signer payment batch). - New PrepareChunkResult model + prepare-chunk-upload / finalize-chunk-upload methods for the single-chunk external-signer publish path. - Mock-daemon tests cover the already-stored and wave-batch branches of chunks/prepare plus visibility forwarding (public, private, omitted) and data_map_address surfacing on finalize. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
Nic-dorman
added a commit
that referenced
this pull request
May 19, 2026
…(V2-312) (#98) Adds the first of 15 SDK examples for the external-signer flow added in PR #90. Exercises both round-trips against `ant dev start --enable-evm`: 1. Public file upload: prepare_upload_public -> approve+payForQuotes -> finalize_upload -> file_download_public, byte-equal assert. 2. Single-chunk publish: prepare_chunk_upload -> approve+payForQuotes -> finalize_chunk_upload -> chunk_get, byte-equal assert. Includes the already_stored short-circuit branch. Loads the bundled IPaymentVault.json (committed in V2-311) from docs/abi/. Signs with anvil deterministic account #0; keys never leave the SDK process - the daemon's only role is to hand over the PaymentIntent and accept tx hashes on finalize. Validated end-to-end on dev2: File: 4 chunks, data_map 57d41c2d..., total 0.059 antToken Chunk: 1 payment, addr 57060540..., round-trip OK Adds the python adapter's `external_signer` short-name; `ant dev example external_signer -l python` and `ant dev example all -l python` now pick it up. Other 14 SDKs follow as separate fan-out PRs.
Nic-dorman
added a commit
that referenced
this pull request
May 21, 2026
Cuts v0.8.0 atop v0.7.1. Substantial breaking-change roll-up of the put/get rename, the private-file PUT/GET gap close, and several minor surface cleanups -- bundled here so the v1.0 cut can ship stable on top. ## Breaking (antd daemon) - feat(antd)!: bind to 127.0.0.1 by default on REST and gRPC (#107). Previously bound 0.0.0.0; use --bind-rest / --bind-grpc to override. - chore: remove dead graph_entry surface from antd proto + 5 SDKs (#92). GraphService and its 4 RPCs are gone; REST mounts dropped. - chore: remove dir_upload_public / dir_download_public surface (#95). Use file_put_public on a directory path instead; the daemon recurses. - feat(antd)!: normalize put/get convention + close private-file PUT and GET gaps (#115). Method renames across proto + REST + SDKs: data_put_private -> data_put data_get_private -> data_get file_upload_public -> file_put_public file_download_public -> file_get_public New: file_put / file_get for the private file path (previously only the public variant existed). New typed results: DataPutResult, DataPutPublicResult, FilePutResult, FilePutPublicResult; PutResult is now annotated as chunk_put only. ## Additive - feat(antd): honor payment_mode on gRPC put/cost paths and REST cost endpoints (#114). Optional kwarg threaded through every put/cost signature; empty/omitted maps to "auto" so older clients keep working. - feat: external-signer public uploads + single-chunk prepare/finalize across 15 SDKs (#90). - docs+spec: openapi.yaml refreshed for the v1.0 surface, including POST /v1/chunks/prepare and /v1/chunks/finalize for single-chunk external-signer publish (#126). ## SDK fan-out (PaymentMode + put/get convention, all 15) #116 antd-go, #117 antd-py/ruby/elixir, #118 antd-rust, #119 antd-csharp, #120 antd-java, #121 antd-swift, #122 antd-dart, #123 antd-kotlin, #124 antd-cpp, #125 antd-js/php/zig/lua, #127 antd-mcp. ## SDK example + build fixes - fix(antd-go): make 03-files example self-contained and runnable (#91) - fix(examples): make 04-files runnable across cpp/rust/elixir/lua/php/ruby/zig (#93) - fix(examples): runnable dart 04_files + java Example03Files; add java Example03Chunks (#94) - feat: gRPC transport example for antd-py and antd-rust (#113) - feat(antd-py): 07_external_signer example + ant-dev dispatcher entry (#98) - feat(antd-js): 07-external-signer example + antd-py empty-payments fix (#99) - feat(rust/go): 07-external-signer examples (#100) - feat(antd-csharp): 07_external_signer example (#101) - feat(antd-java): 07_external_signer example (#102) - feat(antd-kotlin): 07_external_signer example (#103) - feat(antd-dart): 07_external_signer example (#104) - feat(antd-ruby): 07_external_signer example (#105) - feat(antd-php): 07_external_signer example (#106) - chore(antd-kotlin): drop stale GraphDescendant from local proto copy (#108) ## Docs / infra - docs: external-signer flow reference + ABI + python smoke test (#97) - docs: add SECURITY.md with threat model and disclosure policy (#109) - docs!: refresh per-SDK READMEs + llms-full.txt + openapi.yaml for v1.0 surface (#126) - ci: add Go lint + test + vuln scanning for antd-go (#112) - ci: extend antd-rust to sibling-repo parity (fmt + clippy + audit + doc) (#111) - ci: skip antd/openapi.yaml and llms-full.txt from triggering CI (#128) - chore(scripts): add full-stack + integration sweep helpers (#96) - fix(antd-rust): regenerate Cargo.lock to unbreak --locked CI (#110) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates two external-signer surfaces — already shipped in
antd(the daemon) andantd-govia #61 — across the remaining 15 client SDKs so every binding has parity.Public uploads (external-signer):
prepare_upload(path, visibility="public")+ aprepare_upload_public(path)convenience wrapper that bundles the DataMap chunk into the same external-signer payment batch.data_map_addressfield on the finalize-upload result — populated when prepare was public, this is the shareable retrieval handle for the file.data_mapfield also surfaced on finalize (always returned by the daemon).Single-chunk publish (external-signer):
POST /v1/chunks/preparewrapper returning a newPrepareChunkResultmodel. Two response shapes, both supported:already_stored:true(no payment / finalize needed) and the full wave-batch payment intent.POST /v1/chunks/finalizewrapper returning the stored chunk address.15 commits, one per SDK; each commit is independently revertable.
SDKs covered
data_cost/file_costtests that already expected the legacy string return)antd-pyAll test counts are from a single dev2 host with the toolchain matrix described in the testbox README. Every SDK exercises the new surfaces against a mock daemon.
Test plan
data_map_addresssurfaces on public finalize and is empty otherwise;prepare_chunk_uploadalready-stored and wave-batch branches;finalize_chunk_uploadreturns address and forwards body.antddaemon binary (currentmain).Notes
*GrpcClientstubs throwUnsupportedOperationException/NotSupportedExceptionto match the existing pattern.antd-elixircommit also includes two trivial assertion-shape fixes for pre-existingdata_cost/2andfile_cost/3tests that had drifted from the currentUploadCostEstimatereturn type — unrelated to this PR's surfaces but on the same file.🤖 Generated with Claude Code