ci(release): silence Windows build warnings (digicert inputs + pin runner)#131
Merged
Conversation
Two unrelated annotations that fire on every release build's Windows job: 1. `digicert/ssm-code-signing@v1.2.1` only accepts `force-download-tools` as an input (confirmed against the action's action.yml). All credentials are read from env vars — SM_HOST / SM_API_KEY / SM_CLIENT_CERT_PASSWORD are already set at job scope, and SM_CLIENT_CERT_FILE is exported by the preceding step. The `with:` block was a no-op that produced an "Unexpected input(s)" warning. Drop it, along with the now-dead step output and id used to feed it. 2. `windows-latest` will auto-migrate to a VS2026-based image on 2026-06-15. Pin to `windows-2022` so the cutover can't surprise a release mid-flight. A separate PR can validate `windows-2025` ahead of the eventual VS2022 EOL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated annotations fire on every release build's Windows job. This PR addresses both.
1. Drop unsupported
digicert/ssm-code-signinginputsWarning observed on v0.8.0-rc.1 build:
Confirmed against the action's action.yml: the only valid input is
force-download-tools. The action reads everything else from env vars (SM_HOST,SM_API_KEY,SM_CLIENT_CERT_FILE,SM_CLIENT_CERT_PASSWORD), all of which we already set — three at job scope,SM_CLIENT_CERT_FILEvia the precedingcreate client certificate filestep. Thewith:block was a no-op.Also dropped the now-dead
id: prepare_certandsm_client_cert_b64step output that only existed to feed thewith:block.2. Pin Windows runner to
windows-2022Notice observed on v0.8.0-rc.1 build:
Pin to
windows-2022so the auto-migration to a VS2026-based image can't surprise a release mid-flight. VS2026 may affect smctl signing, Tauri MSI bundling, or any of the bash-shell glue we run on the Windows job — none of which we want to debug under tag-push pressure. A separate PR can validatewindows-2025on its own merits ahead of the eventual VS2022 EOL.What's not fixed by this PR
digicert/ssm-code-signing@v1.2.1'saction.ymldeclaresusing: "node20", so the Node 20 deprecation annotation will continue to fire on the Windows job until the maintainer cuts a Node 24 release. That's upstream, not actionable here.Test plan
setup DigiCert SSM toolsstep.smctl healthcheckstill passes (i.e. the env-var-only flow works as expected).verify MSI signaturestep still passes).Windows Server 2022in the job log header.windows-latestredirect NOTICE should no longer appear on the Windows job.🤖 Generated with Claude Code