Merge pull request #58 from bjornstar/develop

v0.0.16: Keys are now being updated properly when splicing arrays.
Wizcorp · Oct 22, 2013 · cf02405 · cf02405
2 parents bb824dc + 44805ba
commit cf02405
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/component.json b/component.json
@@ -2,7 +2,7 @@
   "name": "tomes",
   "repo": "bjornstar/tomes",
   "description": "Evented Storage Agnostic Data API",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "keywords": [ "data", "events" ],
   "dependencies": {
     "component/emitter": "*"

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "tomes",
     "description": "Evented Storage Agnostic Data API",
-    "version": "0.0.15",
+    "version": "0.0.16",
     "author": "Wizcorp, Inc. <info@wizcorp.jp>",
     "maintainers": [
         { "name": "Bjorn Stromberg", "email": "bstromberg@wizcorp.jp" }

diff --git a/scripts/jshint.cfg b/scripts/jshint.cfg
@@ -26,7 +26,6 @@
 
 
     // ECMAScript 5.
-    "es5"           : true,   // Allow ECMAScript 5 syntax.
     "strict"        : false,  // Require `use strict` pragma  in every file.
     "globalstrict"  : true,   // Allow global "use strict" (also enables 'strict').
 

diff --git a/test/modules/array.js b/test/modules/array.js
@@ -1095,5 +1095,21 @@ exports.testSplice = function (test) {
 
 	test.strictEqual(JSON.stringify(a), JSON.stringify(b));
 
+	test.done();
+};
+
+exports.testSpliceKeys = function (test) {
+	test.expect(5);
+
+	var a = [ 0, 1, 2, 3, 4, 5 ];
+	var b = Tome.conjure(a);
+
+	a.splice(0, 1);
+	b.splice(0, 1);
+
+	for (var i = 0; i < b.length; i += 1) {
+		test.strictEqual(i, b[i].getKey());
+	}
+
 	test.done();
 };
diff --git a/tomes.js b/tomes.js
@@ -1259,6 +1259,7 @@ ArrayTome.prototype.splice = function (spliceIndex, toRemove) {
 
 	for (i = 0, len = this._arr.length; i < len; i += 1) {
 		this[i] = this._arr[i];
+		this[i].__key__ = i;
 	}
 
 	if (out.length > toAdd.length) {