Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some views to send to statsd #14

Open
patoroco opened this issue Apr 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@patoroco
Copy link

commented Apr 11, 2019

Hi,

what do you think about to add a new setting with wildcards for those views that you want to track instead of just to track everything with the middleware?

The use case is avoid to send data about django admin for example.

@WoLpH

This comment has been minimized.

Copy link
Owner

commented Apr 11, 2019

In most cases I would argue that it's better to filter it at the graphing side for a few reasons:

  1. Since they would get very little requests they would normally not really impact your numbers too much anyhow
  2. If they do impact the numbers, they are probably quite significant and possibly useful to see

Having that said, it wouldn't be all that hard to implement but there are 2 ways of going about it I guess.

  1. An include/exclude filter by url so we can stop processing very early in the process.
  2. Filter by view name at the end of the process. The result is that it won't filter in all cases, if there's an exception that causes the view name not to be available it will still go through.

Would the filter by url be sufficient for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.