Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETA and AdaptiveETA widgets #12

Closed
Midnighter opened this issue Oct 22, 2014 · 2 comments
Closed

ETA and AdaptiveETA widgets #12

Midnighter opened this issue Oct 22, 2014 · 2 comments

Comments

@Midnighter
Copy link

Hi, just wondering whether you are interested in changing the ETA and AdapativeETA widgets. At the moment their estimation is based on the mean processing time per item:

pbar.seconds_elapsed / pbar.currval

and

per_item = duration / items

respectively. However, the mean is very susceptible to outliers, i.e., a few tasks that took exceptionally long will lead to over estimation of the time needed, whereas a few very short tasks (due to handled exceptions, for example) will lead to gross underestimation of the ETA. I propose to use the median instead, which is statistically much more robust. If you're interested, I can look into making a pull request.

@wolph
Copy link
Owner

wolph commented Oct 23, 2014

Definitely sounds interesting, although (for the sake of API stability) I would opt for either a new method or as a parameter of the ETA/AdaptiveETA methods.

If you'll make a pull request I'll definitely merge it :)

@wolph wolph modified the milestone: 3.0 Complete rewrite Jan 21, 2015
@wolph
Copy link
Owner

wolph commented May 28, 2015

How do you like the current version? We could easily add a different calculation to it now :)

@wolph wolph added the ready label May 29, 2015
@wolph wolph closed this as completed Jul 8, 2015
@wolph wolph removed the ready label Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants