Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] "Clear unused data" command has wiped custom folder contents completely. #119

Closed
Alucard648 opened this issue Apr 21, 2016 · 4 comments
Closed

[Editor] "Clear unused data" command has wiped custom folder contents completely. #119

Alucard648 opened this issue Apr 21, 2016 · 4 comments
Labels
bug Defect / Imperfection Deffects are caused by incompletance or untested and experimental thing... Priority - normal Tech Debt
Projects
Editor
Milestone
PGE Project 0.4.3...

Comments

@Alucard648
Copy link

Alucard648 commented Apr 21, 2016 •
edited by Wohlstand

Title says all.
Before:
unused_wipe1
After:
unused_wipe2
Affected level: https://yadi.sk/d/7dyHRM24rC2jn
Thanks for backup, it makes easier to restore from this bug.
@Wohlstand
Copy link
Member

Totally forgot about usued data cleaner... I made that as a small experiment, and it based on SMBX-64 standard only, therefore new result is invalid. So, I'll continue work on it and it must be finished

P.S. I kept backup making because other reasons: some files are may be useful for another purposes, and I'll let users choice what do with those files - delete them or move away to another place

Wohlstand referenced this issue May 5, 2016
@Wohlstand
Begin works at Level/Episode converter in the Maintainer
f307f95
@Wohlstand Wohlstand changed the title "Clear unused data" command has wiped custom folder contents completely. [Editor] "Clear unused data" command has wiped custom folder contents completely. Jul 8, 2016
@Wohlstand Wohlstand added the bug label Aug 14, 2016
@Wohlstand Wohlstand self-assigned this Aug 14, 2016
@Wohlstand Wohlstand added this to the Editor milestone Aug 14, 2016
@Wohlstand Wohlstand modified the milestones: Editor, Fix all known bugs Oct 10, 2016
@Wohlstand Wohlstand added the Defect / Imperfection Deffects are caused by incompletance or untested and experimental thing... label Dec 1, 2016
@Wohlstand Wohlstand added Priorty - low Task with a low priority, optional, or planned to do for the some future time. Priority - major Task has a Major priority. Has a high importance! Priority - normal and removed Priorty - low Task with a low priority, optional, or planned to do for the some future time. Priority - major Task has a Major priority. Has a high importance! labels Aug 15, 2017
@Wohlstand Wohlstand removed this from the Troubleshooting milestone May 6, 2020
Wohlstand added a commit that referenced this issue May 25, 2020
@Wohlstand
Editor: Polishing the work of unused items cleaner
f186ef1 
#119
@Wohlstand
Copy link
Member

Just now I reworked this feature, now it should work!
Please test the work...

@Wohlstand Wohlstand added the Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others. label May 25, 2020
@Wohlstand Wohlstand assigned Alucard648 and unassigned Wohlstand May 25, 2020
@Alucard648
Copy link
Author

Thanks foe fixing. Now works as intended, no more total wiping.

@Wohlstand Wohlstand removed the Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others. label May 25, 2020
@Wohlstand
Copy link
Member

The main reason for this mess was a relying on GIFs with no counting of PNGs. Also, I had to add counting of INI configs and looking for any possible mentions in local scripts and configs. So, I closing this as a completed.

Editor automation moved this from To do / In work to Completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Defect / Imperfection Deffects are caused by incompletance or untested and experimental thing... Priority - normal Tech Debt
Projects
No open projects
Editor
  
Completed
Milestone
PGE Project 0.4.3 stable release
Development

No branches or pull requests
2 participants
@Wohlstand @Alucard648