Add support of RetroWave OPL3 hardware protocol - #195
Merged
Conversation
Contributor
Author
|
Resolves #190 |
Owner
|
I'll review this once I get my home, on a first look, seems good. One note: if(condition)
{
some();
} |
Contributor
Author
The coding style is changed now. |
Wohlstand
approved these changes
Jan 8, 2023
Wohlstand
left a comment
Owner
There was a problem hiding this comment.
Looks fine to me. I think I'll tweak some other style cases by myself. I'll merge this.
Owner
|
Sorry for the late reply, I was very tired and slept for a long time. |
Contributor
Author
|
You're welcome. Take care. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of RetroWave OPL3 hardware protocol.