Skip to content

Add support of RetroWave OPL3 hardware protocol - #195

Merged
Wohlstand merged 2 commits into
Wohlstand:masterfrom
SudoMaker:master
Jan 8, 2023
Merged

Add support of RetroWave OPL3 hardware protocol#195
Wohlstand merged 2 commits into
Wohlstand:masterfrom
SudoMaker:master

Conversation

@ReimuNotMoe

Copy link
Copy Markdown
Contributor

Add support of RetroWave OPL3 hardware protocol.

@ReimuNotMoe

Copy link
Copy Markdown
Contributor Author

Resolves #190

@Wohlstand

Copy link
Copy Markdown
Owner

I'll review this once I get my home, on a first look, seems good. One note:
We don't use "Egyptian" brackets, so, please follow the code style of project:

if(condition)
{
    some();
}

@ReimuNotMoe

ReimuNotMoe commented Jan 7, 2023

Copy link
Copy Markdown
Contributor Author

I'll review this once I get my home, on a first look, seems good. One note: We don't use "Egyptian" brackets, so, please follow the code style of project:

if(condition)
{
    some();
}

The coding style is changed now.

@Wohlstand Wohlstand left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I think I'll tweak some other style cases by myself. I'll merge this.

@Wohlstand
Wohlstand merged commit 44a988c into Wohlstand:master Jan 8, 2023
@Wohlstand

Copy link
Copy Markdown
Owner

Sorry for the late reply, I was very tired and slept for a long time.

@ReimuNotMoe

Copy link
Copy Markdown
Contributor Author

You're welcome. Take care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants