Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Episode Title & Copy/Erase Options For Saves on Save Select Screen #14

Closed
ChristianSilvermoon opened this issue May 14, 2020 · 15 comments
Assignees
Labels
enhancement New quality-of-life feature or request (does not change gameplay)
Milestone

Comments

@ChristianSilvermoon
Copy link

I always found it a little frustrating to have to manually copy/delete saves with an external program (File Manager, etc.) x3

This would be a very nice quality of life addition in my opinion

Example

EPISODE NAME

SLOT 1... 30  ★x1
SLOT 2... EMPTY
SLOT 3... EMPTY
COPY
ERASE
@Wohlstand Wohlstand self-assigned this May 14, 2020
@Wohlstand Wohlstand added the enhancement New quality-of-life feature or request (does not change gameplay) label May 14, 2020
@Wohlstand
Copy link
Owner

I have a plan to make that, thanks for making a note on that 🦊

@ChristianSilvermoon
Copy link
Author

Awesome ^^

@Wohlstand Wohlstand added this to the Next version milestone Feb 15, 2021
Wohlstand added a commit that referenced this issue Apr 24, 2021
They were needed to implement the copy and deletion of game saves
#14
@Wohlstand
Copy link
Owner

The first step: showing the episode title at the menu
Scr_2021-04-24_11-42-10

@Wohlstand
Copy link
Owner

Made just now!
Scr_2021-04-26_00-12-20

@Wohlstand Wohlstand added the NEED A TEST Completed task that needs a test and confirmation by a reporter label Apr 25, 2021
@Wohlstand
Copy link
Owner

Sent the commit just now

@ChristianSilvermoon
Copy link
Author

Built: cf77a9f

Can confirm, works entirely as expected on
• x86_64 Linux Mint
• armv71l RetroPie
• aarch64 Mobian

Built with:

# Linux Mint (x86_64)
cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizRel -DENABLE_LOGGING=0 ..

# Raspbian/RetroPie (armv7l - Raspberry Pi 4 Model B Rev 1.4 - Piboy DMG)
cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizRel -DENABLE_LOGGING=0 -DUSE_SYSTEM_LIBS=1 ..

# Mobian (aarch64 - Pine64 PinePhone 1.2 )
cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizRel -DENABLE_LOGGING=0 -DUSE_SYSTEM_LIBS=1 ..

Though I've noticed it allows you to "Copy" an empty file. The target file remains unchanged in this instance.

@Wohlstand
Copy link
Owner

Wohlstand commented Apr 26, 2021

Though I've noticed it allows you to "Copy" an empty file. The target file remains unchanged in this instance.

Good notice, I should reject an ability to select an empty file... You right! Right now I do reject the copying into the same file at least.

@Wohlstand
Copy link
Owner

Wohlstand commented Apr 26, 2021

btw, about ARM32 (armv71l) the note that Bowser III'th is broken, however, I got fixed that recently by tuning the floating-point comparison calls that being used to verify the AI state of Bowser III'rd. However, that didn't happen on x86/x86_64 and ARM64...

@Wohlstand
Copy link
Owner

Sent a fix to reject an attempt to copy the empty file

@ChristianSilvermoon
Copy link
Author

Tested out f3f58f8 and it works pretty well (only tested on desktop, this time tho)

@Wohlstand
Copy link
Owner

Also, this feature is a life-important for Emscripten, because you literally has no direct access to the gamesaves store at all, because on how WebAssembly side cache storage works

@ChristianSilvermoon
Copy link
Author

Also, this feature is a life-important for Emscripten, because you literally has no direct access to the gamesaves store at all, because on how WebAssembly side cache storage works

Oh wow, that's a good point, I never even though about that, but yeah. Gosh, web assembly's an interesting tech to have.

@Wohlstand
Copy link
Owner

Wohlstand commented Apr 27, 2021

Gosh, web assembly's an interesting tech to have.

You may see some here:

btw, gotta update these builds here...

EDIT: Heck, something went broken, my game fails to properly start after an update gotta find the reason....

@Wohlstand
Copy link
Owner

They got fixed, but now they don't show the "click to start" title... that odd

@Wohlstand
Copy link
Owner

Anyway, the issue itself is solved 🦊

@Wohlstand Wohlstand removed the NEED A TEST Completed task that needs a test and confirmation by a reporter label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New quality-of-life feature or request (does not change gameplay)
Projects
None yet
Development

No branches or pull requests

2 participants