Random crash for Pokey

[LoveBodhi]

Describe the issue

Random crashes when stacked goomba (Pokey, SMB2, npc-247) freeze with iceball (when set noiceball=0). Sometimes can be frozen, sometime can't, sometime crash.

Example Case

NSMB Classic, World 2-1 (Desert Walk)

Recording

None

Vanilla Recording

None

[Wohlstand]

That's a very weird crash that happens because of the next case: (I investigated just now and found the reason)

• When some of Pokey segments got frozen, it turns into an ice cube
• Other pokey segments expect that the frozen part was one of past segments, now it's an ice cube.
• It sets the Special value with -3
• At Ice cube, the special value is treated as a content NPC ID
• Ice cube tries to find the NPC ID with -3
• Kaboom

That's hard to catch, but, I bet it's fully vanilla crash bug.

[Wohlstand]

So, I fixed that crash just now, should work now.

[0lhi]

Test on 1.3.5.2 lead once to LoveBodhi's Error Message, and sometimes to this:

I could reproduce the latter on 1.3.5.3:

I could not reproduce the Error Message a second time, neither on 1.3.5.2 nor 1.3.5.3.

[Wohlstand]

Error will appear strictly if you will shoot on a specific moment, once the segment will be turned into ice cube at the same moment when other segment checks the bottom if it's pokey segment or not.

[Wohlstand]

The case of ice move is a vanilla mess and is not a topic of this issue, can be put as a separated issue for later work.
So, as the problem got solved, I'll close this.

[Wohlstand]

P.S. to reproduce error message I had to repeat multiple attempts to freeze them, and had to restart level by menu. (I used the level test run that normal episode playing)