Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old and buggy frame counter #27

Closed
3 tasks done
Wohlstand opened this issue Dec 18, 2020 · 2 comments
Closed
3 tasks done

Old and buggy frame counter #27

Wohlstand opened this issue Dec 18, 2020 · 2 comments
Assignees
@Wohlstand
Labels
speedrun Issues related to the speedrun mode. vanilla bug Something isn't working. The old bug which is reproducing on original VB6-built version of game.

Comments

@Wohlstand
Copy link
Collaborator

Wohlstand commented Dec 18, 2020 •
edited

At every place, there is a lot of duplicated code against frame counting and skipping. Also, buggy. Especially when frame-skip is enabled, the game may produce the effect of a fast-forward run after the lag that may cause any unexpected events including the unwanted death of a payable character.

  • Replace all code pieces that counts time with a function that does this inside of self.
  • Fix the fast-forward-after-lag bug when frame-skip enabled.
  • NEW: Regarding this post, the normal framerate must be limited to 64.1025 to match the original game speed and being approvable for speed-runs
@Wohlstand Wohlstand added the vanilla bug Something isn't working. The old bug which is reproducing on original VB6-built version of game. label Dec 18, 2020
@Wohlstand Wohlstand self-assigned this Dec 18, 2020
@Wohlstand Wohlstand changed the title Replace all time/fps count functions with one uniform, and fix bugs in it Old and buggy frame counter Dec 18, 2020
Wohlstand added a commit that referenced this issue Feb 3, 2021
@Wohlstand
Merge a framerate controller copypastas into one module
ad3dafc 
#27
@Wohlstand
Copy link
Collaborator Author

With recent changes, the timer got been improved to guarantee the accurate 64.1025 FPS on almost all supported platforms.

@Wohlstand
Copy link
Collaborator Author

Once I used the new framerate controller code, I accidentally fixed the fast-forward effect completely! I am really happy that was completely done! 🦊

@0lhi 0lhi added the speedrun Issues related to the speedrun mode. label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wohlstand Wohlstand

Labels
speedrun Issues related to the speedrun mode. vanilla bug Something isn't working. The old bug which is reproducing on original VB6-built version of game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wohlstand @0lhi