Create two type of bootstrap (empty - complete) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKOLZ
previously approved these changes
Oct 13, 2017
Contributor
SKOLZ
left a comment
SKOLZ
left a comment
There was a problem hiding this comment.
just those minor things and merge it directly
generators/app/index.js
Outdated
| message: "What type of bootstrap do you want?", | ||
| default: "empty", | ||
| choices: [ | ||
| "empty (react, redux, react-dom, redux-form, redux-beacon, redux-thunk, seamless-immutable, react-redux, react-router, react-router-dom, react-router-redux, react-addons-perf, apisauce, postcss, history, prop-types, lodash, i18next, reselect,)", |
Contributor
There was a problem hiding this comment.
we should remove react-addons-perf since it is deprecated in react 16
| render() { | ||
| return ( | ||
| <StyleRoot> | ||
| <div> |
Contributor
There was a problem hiding this comment.
we can remove this div, just leave the Routes element
| </Switch> | ||
| </div> | ||
| </div> | ||
| <div> |
SKOLZ
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Remove each package question
-- Add only two type of kickoff
-- Remove all unused components