Could renderPageNavMenuItem() be made public, or injectable?

[joho1968]

Looking at modifying the way the menu is created (or rather, the HTML portion of it), I see that renderPageNavMenuItem() is marked as private, thus making it hard to change the rendered output of the public method menu().

It would be nice if this was somehow made injectable or configurable, i.e. what CSS classes are added for the LI and A elements, for active/current elements, and non-active, etc.

(This becomes a real issue when using Bootstrap 5 since the active CSS class is set on the A element, rather than the LI element.)

Just a thought.

[robiso]

This will be implemented via a hook for the renderPageNavMenuItem

You will be able to modify the menu, example:

$Wcms->addListener('renderPageNavMenuItem', 'modifyNavMenuItem');

function modifyNavMenuItem(array $args): array
{
    [$html, $item, $parentSlug, $hasSubpages] = $args;
    
    // Example: Add a custom class to blog items
    if ($item->slug === 'blog') {
        $html = str_replace(
            '<li class="nav-item', 
            '<li class="nav-item blog-item', 
            $html
        );
    }

    // Example: Add data attributes
    $html = str_replace(
        '<a class="nav-link"',
        '<a class="nav-link" data-menu-id="' . $item->slug . '"',
        $html
    );

    return [$html];
}

[robiso]

@joho1968 in PR #327