Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android #5

Merged
merged 10 commits into from Aug 13, 2019

Conversation

@jorgemarrero
Copy link
Member

commented Aug 13, 2019

I have included a prop called saveOnDevice by default to false.

Now the image is saved in a cache directory so we can upload the image without saving it to the device, without asking for storage permission.

This PR also includes Android support made by the original library 馃檶

gif

Resolves #1

@jorgemarrero jorgemarrero requested a review from sejas Aug 13, 2019

@sejas sejas self-assigned this Aug 13, 2019

@sejas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@jorgemarrero could you edit the description with the issues this PR resolves? #1 ... ?

Thanks !!

@jorgemarrero

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@jorgemarrero could you edit the description with the issues this PR resolves? #1 ?

Thanks !!

Sure! Done 馃挭

@sejas

sejas approved these changes Aug 13, 2019

Copy link
Member

left a comment

It works awesome !! 馃檶
Great job !!
PS. The phone heats up a lot 馃槤

Screenshot_20190813-170204

@sejas sejas merged commit cf727fd into master Aug 13, 2019

@sejas sejas deleted the android branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.