From 7b1744c425ab6fad32015aa687bef13b08d02bcb Mon Sep 17 00:00:00 2001
From: Woopicus <bart_drongelen@hotmail.com>
Date: Wed, 5 Nov 2025 10:41:07 +0100
Subject: [PATCH 1/2] Added declare(strict_types=1);

---
 src/Command/GetMessagesCommand.php   | 3 ---
 src/Controller/MessageController.php | 3 ---
 src/DTO/CreateMessageDTO.php         | 3 ---
 src/DTO/UpdateMessageDTO.php         | 3 ---
 src/Entity/Message.php               | 3 ---
 src/Repository/MessageRepository.php | 3 ---
 src/Service/MessageService.php       | 3 ---
 7 files changed, 21 deletions(-)

diff --git a/src/Command/GetMessagesCommand.php b/src/Command/GetMessagesCommand.php
index 05fee05..47cb9ab 100644
--- a/src/Command/GetMessagesCommand.php
+++ b/src/Command/GetMessagesCommand.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\Command;
 
 use App\Service\MessageService;
diff --git a/src/Controller/MessageController.php b/src/Controller/MessageController.php
index 4aaa656..d4dd719 100644
--- a/src/Controller/MessageController.php
+++ b/src/Controller/MessageController.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\Controller;
 
 use App\DTO\UpdateMessageDTO;
diff --git a/src/DTO/CreateMessageDTO.php b/src/DTO/CreateMessageDTO.php
index 0543ce9..66097b3 100644
--- a/src/DTO/CreateMessageDTO.php
+++ b/src/DTO/CreateMessageDTO.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\DTO;
 
 class CreateMessageDTO
diff --git a/src/DTO/UpdateMessageDTO.php b/src/DTO/UpdateMessageDTO.php
index a2f4aeb..a871fcb 100644
--- a/src/DTO/UpdateMessageDTO.php
+++ b/src/DTO/UpdateMessageDTO.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\DTO;
 
 class UpdateMessageDTO
diff --git a/src/Entity/Message.php b/src/Entity/Message.php
index e4c6f25..dcc0f64 100644
--- a/src/Entity/Message.php
+++ b/src/Entity/Message.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\Entity;
 
 use App\Repository\MessageRepository;
diff --git a/src/Repository/MessageRepository.php b/src/Repository/MessageRepository.php
index 17e76fb..91f4ca9 100644
--- a/src/Repository/MessageRepository.php
+++ b/src/Repository/MessageRepository.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\Repository;
 
 use App\Entity\Message;
diff --git a/src/Service/MessageService.php b/src/Service/MessageService.php
index b4aec0a..33a0b55 100644
--- a/src/Service/MessageService.php
+++ b/src/Service/MessageService.php
@@ -1,8 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
 namespace App\Service;
 
 use App\Entity\Message;

From 1bdcd6b51790346b9d4bdd7d46afc8a2a31e95c6 Mon Sep 17 00:00:00 2001
From: Woopicus <bart_drongelen@hotmail.com>
Date: Wed, 5 Nov 2025 11:43:13 +0100
Subject: [PATCH 2/2] Added declare(strict_types=1); (for real this time)

Changed Method_Created to HTTP JsonResponses
---
 src/Command/GetMessagesCommand.php   |  2 ++
 src/Controller/MessageController.php | 13 +++++++------
 src/DTO/CreateMessageDTO.php         |  2 ++
 src/DTO/UpdateMessageDTO.php         |  2 ++
 src/Entity/Message.php               |  2 ++
 src/Repository/MessageRepository.php |  2 ++
 src/Service/MessageService.php       |  2 ++
 7 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/src/Command/GetMessagesCommand.php b/src/Command/GetMessagesCommand.php
index 47cb9ab..2b2272b 100644
--- a/src/Command/GetMessagesCommand.php
+++ b/src/Command/GetMessagesCommand.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Command;
 
 use App\Service\MessageService;
diff --git a/src/Controller/MessageController.php b/src/Controller/MessageController.php
index d4dd719..6c6428b 100644
--- a/src/Controller/MessageController.php
+++ b/src/Controller/MessageController.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Controller;
 
 use App\DTO\UpdateMessageDTO;
@@ -7,7 +9,6 @@
 use App\Service\MessageService;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Serializer\SerializerInterface;
 
@@ -23,7 +24,7 @@ public function getMessages(): JsonResponse
     {
         $messages = $this->messageService->getMessages();
 
-        return $this->json(['data' => $messages]);
+        return $this->json(['data' => $messages], JsonResponse::HTTP_OK);
     }
 
     #[Route('/api/messages/{messageId}', methods: ['GET'])]
@@ -31,21 +32,21 @@ public function getMessage(int $messageId): JsonResponse
     {
         $message = $this->messageService->getMessage($messageId);
 
-        return $this->json(['data' => $message]);
+        return $this->json(['data' => $message], JsonResponse::HTTP_OK);
     }
 
     #[Route('/api/messages', methods: ['POST'])]
     public function createMessage(#[RequestDto] CreateMessageDTO $dto): JsonResponse
     {
         $message = $this->messageService->createMessage($dto);
-        return $this->json(['data' => $message], JsonResponse::Method_CREATED);
+        return $this->json(['data' => $message], JsonResponse::HTTP_CREATED);
     }
 
     #[Route('/api/messages/{messageId}', methods: ['PUT'])]
     public function updateMessage(int $messageId, #[RequestDto] UpdateMessageDTO $dto): JsonResponse
     {
         $message = $this->messageService->updateMessage($messageId, $dto);
-        return $this->json(['data' => $message], JsonResponse::Method_CREATED);
+        return $this->json(['data' => $message], JsonResponse::HTTP_OK);
     }
 
     #[Route('/api/messages/{messageId}', methods: ['DELETE'])]
@@ -53,6 +54,6 @@ public function removeMessage(int $messageId): JsonResponse
     {
         $this->messageService->removeMessage($messageId);
 
-        return $this->json(null, JsonResponse::Method_CREATED);
+        return $this->json([], JsonResponse::HTTP_NO_CONTENT);
     }
 }
diff --git a/src/DTO/CreateMessageDTO.php b/src/DTO/CreateMessageDTO.php
index 66097b3..8687cfc 100644
--- a/src/DTO/CreateMessageDTO.php
+++ b/src/DTO/CreateMessageDTO.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\DTO;
 
 class CreateMessageDTO
diff --git a/src/DTO/UpdateMessageDTO.php b/src/DTO/UpdateMessageDTO.php
index a871fcb..3180a97 100644
--- a/src/DTO/UpdateMessageDTO.php
+++ b/src/DTO/UpdateMessageDTO.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\DTO;
 
 class UpdateMessageDTO
diff --git a/src/Entity/Message.php b/src/Entity/Message.php
index dcc0f64..f046050 100644
--- a/src/Entity/Message.php
+++ b/src/Entity/Message.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Entity;
 
 use App\Repository\MessageRepository;
diff --git a/src/Repository/MessageRepository.php b/src/Repository/MessageRepository.php
index 91f4ca9..a9da3f0 100644
--- a/src/Repository/MessageRepository.php
+++ b/src/Repository/MessageRepository.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Repository;
 
 use App\Entity\Message;
diff --git a/src/Service/MessageService.php b/src/Service/MessageService.php
index 33a0b55..de435b3 100644
--- a/src/Service/MessageService.php
+++ b/src/Service/MessageService.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Service;
 
 use App\Entity\Message;