New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give_Notices: Non-dismissible notices shouldn't have "x" icon #2100

Closed
DevinWalker opened this Issue Sep 20, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@DevinWalker
Contributor

DevinWalker commented Sep 20, 2017

Issue Overview

If you create a non-dismissible notice the "x" icon appears. Clicking it removes the notice but on page reload the notice reappears.

2017-09-20_15-41-07

See how Gift Aid adds a notice:

Give()->notices->register_notice( array(
				'id'          => 'gift-aid-country-notice',
				'type'        => 'error',
				'description' => sprintf(
					__( 'The United Kingdom must be set as the base country within Give\'s <a href="%s">General Settings</a> in order to collect Gift Aid.', 'give-gift-aid' ),
					admin_url( 'edit.php?post_type=give_forms&page=give-settings&tab=general' )
				),
				'show'        => true,
			) );

Expected Behavior

  • Non-dismissible notices don't have an "x" icon

Current Behavior

A dismiss icon appears

@DevinWalker DevinWalker added this to the 1.8.14 milestone Sep 20, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 21, 2017

@raftaar1191 raftaar1191 referenced this issue Sep 21, 2017

Merged

Fix Non-dismissible notices #2100 #2109

3 of 3 tasks complete
@raftaar1191

This comment has been minimized.

Show comment
Hide comment
@raftaar1191

raftaar1191 Sep 25, 2017

Contributor

Customize Give_Notices API

  1. Deprecate auto_dismissible option with backwards compatibility

  2. Create new dismissible option to replace it with the following options:
    - auto - notices are removed automatically like with auto_dismissible set to true
    - false no “x” icon at all, non-dismissible
    - dismissible is set to true by default

Contributor

raftaar1191 commented Sep 25, 2017

Customize Give_Notices API

  1. Deprecate auto_dismissible option with backwards compatibility

  2. Create new dismissible option to replace it with the following options:
    - auto - notices are removed automatically like with auto_dismissible set to true
    - false no “x” icon at all, non-dismissible
    - dismissible is set to true by default

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 25, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 26, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 26, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 26, 2017

@ravinderk ravinderk added the has pr label Sep 26, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 26, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 26, 2017

ravinderk added a commit that referenced this issue Sep 26, 2017

@ravinderk ravinderk closed this Sep 26, 2017

@DevinWalker

This comment has been minimized.

Show comment
Hide comment
@DevinWalker

DevinWalker Sep 27, 2017

Contributor

Reopening because @mehul0810 found an annoying bug that should be resolved:

When clicking the dismiss icon the give-message query arg should be removed in the URL.

Contributor

DevinWalker commented Sep 27, 2017

Reopening because @mehul0810 found an annoying bug that should be resolved:

When clicking the dismiss icon the give-message query arg should be removed in the URL.

@DevinWalker DevinWalker reopened this Sep 27, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 28, 2017

Remove give-message parameter #2100
Remove the give-message parameter from url once user click on the remove notices button

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 28, 2017

Fix donations status url #2100
Fix donatiosn status url issues once after user send the resend recipt

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Sep 28, 2017

Fix donations status url #2100
Fix donatiosn status url issues once after user send the resend recipt

DevinWalker added a commit that referenced this issue Sep 28, 2017

DevinWalker added a commit that referenced this issue Sep 29, 2017

Merge branch 'release/1.8.14' into release/1.8.15
* release/1.8.14: (34 commits)
  Improve importer csv validation
  Fix donations status url #2100
  Remove give-message parameter #2100
  Improved text
  Restriction for donation removed completely.
  Restricted give_profile_editor
  Implemented restriction to donation if loggedin user and donor-user profile are disconnected
  Added Restriction to donation
  Remove Email and Login Restriction on Donor and User Disconnection
  Filtered Email Tags
  Improvement in Email
  Code, Comment and Logic Improvement
  Code and Comment Improvement
  Comment Improvement and Translate strings improvement
  Code Structuring Improvement
  Comment Improvement
  Minor Notice Fix
  Minor Correction
  Improved User Address Saving Logic
  Added redirection url attribute to output when user click disconnect user
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment